Summary: | sys-apps/memtest86+-5.01: version bump | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Maks <mgenaev> |
Component: | [OLD] Core system | Assignee: | Gentoo's Team for Core System packages <base-system> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | alexander, ansla80, bertrand, bircoph, dschridde+gentoobugs, eugene.shalygin, gentoo, j6yNRdsH5Fc3, kroemmelbein, necheffa.misc, realnc, sven.koehler, xmw |
Priority: | Normal | Keywords: | EBUILD |
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
New version ebuild
Diff -u memtest86+ 4.20-r1 and 5.01 Fixes build with gcc 4.7.3-r1 |
Description
Maks
2013-09-30 10:57:27 UTC
Created attachment 359784 [details]
New version ebuild
Please attach unified diffs (diff -u) when you did changes to an ebuild. That would be much more handy for us. Created attachment 359788 [details, diff]
Diff -u memtest86+ 4.20-r1 and 5.01
Seems like memtest86+-5.01 crashes with recent gcc versions: http://forum.canardpc.com/threads/83443-Memtest86-V5.01-crashes-with-gcc-4.7.2-or-later Since we stabilized gcc-4.7.3 recently I won't bump memtest86+ to this version unless there's a patch available. Created attachment 379408 [details, diff] Fixes build with gcc 4.7.3-r1 This patch does three things: 1) removes optimizations 2) fixes variables that should have been set to static 3) fixes array upper limit in for loops used to scan PCI devices. Its meant to be applied after the scp command is removed from the "make all" option; see the sed magic from the previously attached patch here: https://486564.bugs.gentoo.org/attachment.cgi?id=359788 I've taken the array fix from the Fedora package of memtest86+ (not sure if that matters?). Also forgive me if anything is off color, this is one of my first patches. :-D *** Bug 523460 has been marked as a duplicate of this bug. *** With patch proposed above 5.0.1 works fine after compilation with gcc-4.8.3. Ping. Dear base team, I'm going to add 5.0.1 in tree (with the patch above) it two weeks if there are no objections. This bug is pending now for too long and people are in high demand of this tool. Please proceed now Andrew, the concerns that Lars had look to have been addressed. Any further issues can be dealt with in new bugs. Sorry for the delay. In tree now. Aside from gcc-4.7.3 patch I ported patch to remove hardcoded CC/AS and added QA_FLAGS_IGNORED, since we don't allow users to change CFLAGS anyway. |