| Summary: | dev-python/root_numpy: plays with python wrapping internals (unnecessarily) | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Michał Górny <mgorny> |
| Component: | Current packages | Assignee: | Gentoo Science Physics related packages <sci-physics> |
| Status: | RESOLVED FIXED | ||
| Severity: | QA | ||
| Priority: | Normal | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| See Also: | https://bugs.gentoo.org/show_bug.cgi?id=483354 | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Bug Depends on: | |||
| Bug Blocks: | 484398 | ||
| Attachments: | patch to ebuild | ||
Created attachment 358640 [details, diff]
patch to ebuild
Please let me know if this patch is ok to commit.
Changes:
1. enforced a single impl since sci-physics/root supports that only,
2. required USE=python on sci-physics/root,
3. fixed the nosetests invocation,
4. fixed EXAMPLES not to be compressed.
(In reply to Michał Górny from comment #1) > Created attachment 358640 [details, diff] [details, diff] > patch to ebuild > > Please let me know if this patch is ok to commit. yes please do and feel free to do the same to all the other similar python bugs you filed Committed. |
python_test() { cd ${BUILD_DIR} || die nosetests-${EPYTHON} -v || die "Testing failed with ${EPYTHON}" ^^^^^^^^^^^ } Please don't play with internals like this. 'nosetests' is a wrapper, and eclass sets up environment properly, so the wrapper will choose correct implementation.