Bug 480438 – app-emulation/qemu-guest-agent-1.4.2 - pidfile in /var/run - should be in /run

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Bertrand Jacquin 2013-08-09 22:51:16 UTC]

qemu-guest-agent init script launch start-stop-daemon with argument '--pidfile /var/run/qemu-ga.pid' in start() and stop() functions. Instead of /var/run /run should be used for pid-files as describe in #361349.

This result by qemu-guest-agent could not start :

# /etc/init.d/qemu-guest-agent start
 * Caching service dependencies ...                                                                  [ ok
 * Starting QEMU Guest Agent ...
1376088593.550871: critical: Cannot lock pid file, No such file or directory
1376088593.550916: critical: failed to create pidfile


Reproducible: Always

[Comment 1 Sergei Trofimovich (RETIRED) 2013-08-11 14:24:40 UTC]

Please, show your output for
    $ ls -ld /run /var/run
and
    $ emerge --info

At least on linux after proper migration /var/run should point to the /run.

[Comment 2 Bertrand Jacquin 2013-08-11 14:33:33 UTC]

Created attachment 355692 [details]
emerge --info

(In reply to Sergei Trofimovich from comment #1)
> Please, show your output for
>     $ ls -ld /run /var/run

$ ls -ld /var/run
lrwxrwxrwx 1 root root 4 Sep  7  2012 /var/run -> /run

> and
>     $ emerge --info
> 
> At least on linux after proper migration /var/run should point to the /run.

[Comment 3 Sergei Trofimovich (RETIRED) 2013-08-11 17:16:05 UTC]

(In reply to Bertrand Jacquin from comment #2)
> Created attachment 355692 [details]
> emerge --info
> 
> (In reply to Sergei Trofimovich from comment #1)
> > Please, show your output for
> >     $ ls -ld /run /var/run
> 
> $ ls -ld /var/run
> lrwxrwxrwx 1 root root 4 Sep  7  2012 /var/run -> /run
> 
> > and
> >     $ emerge --info
> > 
> > At least on linux after proper migration /var/run should point to the /run.

Oh, our qemu-guest-agent completely broken.
It's default paths are /usr/loca/ relative.
Including default PID path.

>>> Configuring source in /tmp/portage/app-emulation/qemu-guest-agent-1.5.2/work/qemu-1.5.2 ...
Install prefix    /usr/local
BIOS directory    /usr/local/share/qemu
binary directory  /usr/local/bin
library directory /usr/local/lib
libexec directory /usr/local/libexec
include directory /usr/local/include
config directory  /usr/local/etc
local state directory   /usr/local/var
Manual directory  /usr/local/share/man
ELF interp prefix /usr/gnemul/qemu-%M
Source path       /tmp/portage/app-emulation/qemu-guest-agent-1.5.2/work/qemu-1.5.2

[Comment 4 Doug Goldstein (RETIRED) 2013-08-11 21:22:29 UTC]

(In reply to Sergei Trofimovich from comment #3)
> (In reply to Bertrand Jacquin from comment #2)
> > Created attachment 355692 [details]
> > emerge --info
> > 
> > (In reply to Sergei Trofimovich from comment #1)
> > > Please, show your output for
> > >     $ ls -ld /run /var/run
> > 
> > $ ls -ld /var/run
> > lrwxrwxrwx 1 root root 4 Sep  7  2012 /var/run -> /run
> > 
> > > and
> > >     $ emerge --info
> > > 
> > > At least on linux after proper migration /var/run should point to the /run.
> 
> Oh, our qemu-guest-agent completely broken.
> It's default paths are /usr/loca/ relative.
> Including default PID path.
> 
> >>> Configuring source in /tmp/portage/app-emulation/qemu-guest-agent-1.5.2/work/qemu-1.5.2 ...
> Install prefix    /usr/local
> BIOS directory    /usr/local/share/qemu
> binary directory  /usr/local/bin
> library directory /usr/local/lib
> libexec directory /usr/local/libexec
> include directory /usr/local/include
> config directory  /usr/local/etc
> local state directory   /usr/local/var
> Manual directory  /usr/local/share/man
> ELF interp prefix /usr/gnemul/qemu-%M
> Source path      
> /tmp/portage/app-emulation/qemu-guest-agent-1.5.2/work/qemu-1.5.2

Bummer. I asked someone to test it a while back before committing the original and all I've done since then are bumps.

There should now be qemu-1.5.2-r1 and should have the issues fixed.

[Comment 5 Doug Goldstein (RETIRED) 2013-08-11 21:22:46 UTC]

Please let me know if that solves the issue.

[Comment 6 Doug Goldstein (RETIRED) 2013-08-11 21:32:02 UTC]

That should have been qemu-guest-agent-1.5.2-r1.

[Comment 7 Bertrand Jacquin 2013-08-12 17:33:21 UTC]

(In reply to Doug Goldstein from comment #4)
> (In reply to Sergei Trofimovich from comment #3)
> > (In reply to Bertrand Jacquin from comment #2)
> > > Created attachment 355692 [details]
> > > emerge --info
> > > 
> > > (In reply to Sergei Trofimovich from comment #1)
> > > > Please, show your output for
> > > >     $ ls -ld /run /var/run
> > > 
> > > $ ls -ld /var/run
> > > lrwxrwxrwx 1 root root 4 Sep  7  2012 /var/run -> /run
> > > 
> > > > and
> > > >     $ emerge --info
> > > > 
> > > > At least on linux after proper migration /var/run should point to the /run.
> > 
> > Oh, our qemu-guest-agent completely broken.
> > It's default paths are /usr/loca/ relative.
> > Including default PID path.
> > 
> > >>> Configuring source in /tmp/portage/app-emulation/qemu-guest-agent-1.5.2/work/qemu-1.5.2 ...
> > Install prefix    /usr/local
> > BIOS directory    /usr/local/share/qemu
> > binary directory  /usr/local/bin
> > library directory /usr/local/lib
> > libexec directory /usr/local/libexec
> > include directory /usr/local/include
> > config directory  /usr/local/etc
> > local state directory   /usr/local/var
> > Manual directory  /usr/local/share/man
> > ELF interp prefix /usr/gnemul/qemu-%M
> > Source path      
> > /tmp/portage/app-emulation/qemu-guest-agent-1.5.2/work/qemu-1.5.2
> 
> Bummer. I asked someone to test it a while back before committing the
> original and all I've done since then are bumps.
> 
> There should now be qemu-1.5.2-r1 and should have the issues fixed.

I can confirm this is OK. Thanks Doug.

[Comment 8 Doug Goldstein (RETIRED) 2013-08-12 19:34:00 UTC]

(In reply to Bertrand Jacquin from comment #7)
> 
> I can confirm this is OK. Thanks Doug.

YW. Let me know if there's other issues.