Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 472928

Summary: gnome2.eclass doesn't support PATCHES variable
Product: Gentoo Linux Reporter: Yixun Lan <dlan>
Component: EclassesAssignee: Gentoo Linux Gnome Desktop Team <gnome>
Status: RESOLVED WONTFIX    
Severity: enhancement CC: esigra, nikoli
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
See Also: https://bugs.gentoo.org/show_bug.cgi?id=413299
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 262490    

Description Yixun Lan archtester gentoo-dev 2013-06-11 00:49:56 UTC
writing as following does not take effect in gnome2.eclass, 
PATCHES=(
    "${FILESDIR}"/${PN}-3.0.3-zlib-1.2.5.2.patch
    )

It would be great to add this support, thanks


Reproducible: Always
Comment 1 Gilles Dartiguelongue (RETIRED) gentoo-dev 2013-12-23 10:02:55 UTC
It is sad that the logic to handle this is spread in so many eclasses yet each have their own little differences.

I think for gnome2.eclass, the best alternative is to check if we can use autotools-utils src_prepare as it has a nice logic for checking if autoreconf is needed and also handles epatch_user.

The rest of the phases are more questionable as it would introduce out-of-source builds and a few other features that we might want to avoid for now.
Comment 2 Pacho Ramos gentoo-dev 2015-12-16 12:04:58 UTC
We will simply rely on builtin functionality with eapi6 as soon as eclasses are updated for that eapi