Summary: | support USE_EXPAND prefix in package.use | ||
---|---|---|---|
Product: | Portage Development | Reporter: | Tiziano Müller (RETIRED) <dev-zero> |
Component: | Enhancement/Feature Requests | Assignee: | Portage team <dev-portage> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | gentoo, jcallen, mgorny, sera, slyfox |
Priority: | Normal | Keywords: | InVCS |
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | http://thread.gmane.org/gmane.linux.gentoo.portage.devel/5138 | ||
See Also: | https://bugs.gentoo.org/show_bug.cgi?id=922307 | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 484436 |
Description
Tiziano Müller (RETIRED)
![]() I would suggest the following syntax in package.use: cat/pn flag1 SOME_USE_EXPAND="flag2 -flag3" OTHER_USE_EXPAND="flag4" flag5 (In reply to Arfrever Frehtes Taifersar Arahesis from comment #1) > I would suggest the following syntax in package.use: > > cat/pn flag1 SOME_USE_EXPAND="flag2 -flag3" OTHER_USE_EXPAND="flag4" flag5 To make it harder to parse, incompatible to existing syntax and different in nature to a possible future unified DEPENDENCIES using labels? (In reply to Ralph Sennhauser from comment #2) > To make it harder to parse, incompatible to existing syntax and different in > nature to a possible future unified DEPENDENCIES using labels? While I don't think we must take features which may or may not get implemented at some point in the future into account I would prefer a syntax which is similar or equal to something which already exists, like paludis' use.conf: cat/foo usualflag SOME_USE_EXPAND: someflag OTHER_USE_EXPAND: yetanotherflag cat/foo usualflag some_use_expand: someflag other_use_expand: yetanotherflag given that it needs less specification (single/double quotes, variable substition possible, etc.) and is probably a bit easier to parse (no need to look for matching quotes). I'd say we go for the 'FOO:' form. This has the extra advantage of being compatible with paludis format [1]. Less divergence, less confusion. [1]:http://paludis.exherbo.org/configuration/use.html Here's the final patch for review. Now you have to convince dol-sen to accept it ;). /me silently swaps patches for the correct one. Released in portage-2.2.16. |