| Summary: | x11-themes/light-themes: using Ambiance theme with GNOME 3.8.x results in to incorrectly drawn menu in many apps | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Evgeny Bobkin <evgen.ibqn> |
| Component: | [OLD] GNOME | Assignee: | Sebastian Pipping <sping> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | gnome, pacho |
| Priority: | Normal | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Bug Depends on: | |||
| Bug Blocks: | 463242 | ||
| Attachments: |
broken menu in gnome-terminal 3.8.1 with Ambiance theme
broken menu in nautilus 3.8.1 with Ambiance theme modified ambiance patch modified radiance patch separator issue menu separator issue in gnome-terminal that is how it should look like in gnome-terminal |
||
|
Description
Evgeny Bobkin
2013-05-08 13:26:17 UTC
Created attachment 347752 [details]
broken menu in gnome-terminal 3.8.1 with Ambiance theme
Created attachment 347754 [details]
broken menu in nautilus 3.8.1 with Ambiance theme
What light-themes version are you running? this one 0.1.93 +*light-themes-0.1.93-r1 (09 May 2013) + + 09 May 2013; Pacho Ramos <pacho@gentoo.org> + +files/light-themes-0.1.93-gtk3.8-1.patch, + +files/light-themes-0.1.93-gtk3.8-2.patch, +light-themes-0.1.93-r1.ebuild, + -light-themes-0.1.11.ebuild: + Fix gtk+-3.8 compat (#469062 by Evgeny Bobkin), and fix colors for Gentoo + variants. + thank you Pacho, it's almost fixed but not totally, there is a small issue with a menu separator line remained. FIX NEEDED)) and can this be that this change can break the look in gtk+-3.6.x? Created attachment 347906 [details, diff]
modified ambiance patch
Created attachment 347908 [details]
modified radiance patch
I have created it against the latest source of ubuntu-theme found here https://launchpad.net/ubuntu/saucy/+source/ubuntu-themes/ by https://launchpad.net/ubuntu/saucy/+source/ubuntu-themes/ with $ diff ./light-themes-0.1.93/Ambiance/ ./ubuntu-themes-13.04daily13.04.12/Ambiance/ -urN > light-themes-gtk3.8-ambiance.patch $ diff ./light-themes-0.1.93/Radiance/ ./ubuntu-themes-13.04daily13.04.12/Radiance/ -urN > light-themes-gtk3.8-radiance.patch Patches are tested and the remaining menu separator issue is fixed. This could suggest that if ubuntu boys do not care about light-themes any more and use ubuntu-themes instead, should we also switch, soon? This should be however verified)) additionally if you take a closer look at the radiance patch, then it can be seen that some images were modified as well. Will try to bump to a snapshot if possible :/ (In reply to comment #6) > thank you Pacho, it's almost fixed but not totally, there is a small issue > with a menu separator line remained. > > FIX NEEDED)) Anyway, could you post a screenshot? When I committed it I didn't saw any strange line (In reply to comment #10) [...] > This could suggest that if ubuntu boys do not care about light-themes any > more and use ubuntu-themes instead, should we also switch, soon? > > This should be however verified)) Looks like Ubuntu has merged all his themes (this and icons) in one package... For now I would apply your patch. For the long term, I need other maintainers opinions to decide if we should move to the merged package or not (I would probably wait to next Ubuntu stable version to be sure they don't change their mind again) Created attachment 347968 [details]
separator issue
Created attachment 347970 [details]
menu separator issue in gnome-terminal
Ah, I thought that was intentional :O Created attachment 347972 [details]
that is how it should look like in gnome-terminal
+*light-themes-0.1.93-r2 (11 May 2013) + + 11 May 2013; Pacho Ramos <pacho@gentoo.org> + +files/light-themes-0.1.93-gtk3.8-3.patch, +light-themes-0.1.93-r2.ebuild, + -light-themes-0.1.93-r1.ebuild: + Fix remaining gtk+-3.8 issue (#469062 by Evgeny Bobkin) + |
