Bug 469062 – x11-themes/light-themes: using Ambiance theme with GNOME 3.8.x results in to incorrectly drawn menu in many apps

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Evgeny Bobkin 2013-05-08 13:26:17 UTC]

Once the Ambiance theme is selected with gnome tweak tool (Theme -> Gtk+ Theme -> Ambiance) the menu in gnome-terminal and the pop-up menu in nautilus and in many other apps are drawn incorrectly. please see the attached screenshots

Reproducible: Always

[Comment 1 Evgeny Bobkin 2013-05-08 13:27:49 UTC]

Created attachment 347752 [details]
broken menu in gnome-terminal 3.8.1 with Ambiance theme

[Comment 2 Evgeny Bobkin 2013-05-08 13:28:56 UTC]

Created attachment 347754 [details]
broken menu in nautilus 3.8.1 with Ambiance theme

[Comment 3 Pacho Ramos 2013-05-08 18:23:50 UTC]

What light-themes version are you running?

[Comment 4 Evgeny Bobkin 2013-05-08 22:10:50 UTC]

this one 0.1.93

[Comment 5 Pacho Ramos 2013-05-09 18:28:38 UTC]

+*light-themes-0.1.93-r1 (09 May 2013)
+
+  09 May 2013; Pacho Ramos <[e-mail]>
+  +files/light-themes-0.1.93-gtk3.8-1.patch,
+  +files/light-themes-0.1.93-gtk3.8-2.patch, +light-themes-0.1.93-r1.ebuild,
+  -light-themes-0.1.11.ebuild:
+  Fix gtk+-3.8 compat (#469062 by Evgeny Bobkin), and fix colors for Gentoo
+  variants.
+

[Comment 6 Evgeny Bobkin 2013-05-10 07:13:46 UTC]

thank you Pacho, it's almost fixed but not totally, there is a small issue with a menu separator line remained.

FIX NEEDED))

[Comment 7 Evgeny Bobkin 2013-05-10 07:15:19 UTC]

and can this be that this change can break the look in gtk+-3.6.x?

[Comment 8 Evgeny Bobkin 2013-05-10 07:48:08 UTC]

Created attachment 347906 [details, diff]
modified ambiance patch

[Comment 9 Evgeny Bobkin 2013-05-10 07:48:44 UTC]

Created attachment 347908 [details]
modified radiance patch

[Comment 10 Evgeny Bobkin 2013-05-10 07:55:21 UTC]

I have created it against the latest source of ubuntu-theme found here
https://launchpad.net/ubuntu/saucy/+source/ubuntu-themes/

by https://launchpad.net/ubuntu/saucy/+source/ubuntu-themes/

with 

 $ diff ./light-themes-0.1.93/Ambiance/ ./ubuntu-themes-13.04daily13.04.12/Ambiance/ -urN > light-themes-gtk3.8-ambiance.patch

 $ diff ./light-themes-0.1.93/Radiance/ ./ubuntu-themes-13.04daily13.04.12/Radiance/ -urN > light-themes-gtk3.8-radiance.patch

Patches are tested and the remaining menu separator issue is fixed.

This could suggest that if ubuntu boys do not care about light-themes any more and use ubuntu-themes instead, should we also switch, soon?

This should be however verified))

[Comment 11 Evgeny Bobkin 2013-05-10 08:01:18 UTC]

additionally if you take a closer look at the radiance patch, then it can be seen that some images were modified as well.

[Comment 12 Pacho Ramos 2013-05-11 00:08:50 UTC]

Will try to bump to a snapshot if possible :/

[Comment 13 Pacho Ramos 2013-05-11 07:15:40 UTC]

(In reply to comment #6)
> thank you Pacho, it's almost fixed but not totally, there is a small issue
> with a menu separator line remained.
> 
> FIX NEEDED))

Anyway, could you post a screenshot? When I committed it I didn't saw any strange line

[Comment 14 Pacho Ramos 2013-05-11 07:17:20 UTC]

(In reply to comment #10)
[...]
> This could suggest that if ubuntu boys do not care about light-themes any
> more and use ubuntu-themes instead, should we also switch, soon?
> 
> This should be however verified))

Looks like Ubuntu has merged all his themes (this and icons) in one package...  For now I would apply your patch. For the long term, I need other maintainers opinions to decide if we should move to the merged package or not (I would probably wait to next Ubuntu stable version to be sure they don't change their mind again)

[Comment 15 Evgeny Bobkin 2013-05-11 08:11:44 UTC]

Created attachment 347968 [details]
separator issue

[Comment 16 Evgeny Bobkin 2013-05-11 08:12:38 UTC]

Created attachment 347970 [details]
menu separator issue in gnome-terminal

[Comment 17 Pacho Ramos 2013-05-11 08:18:13 UTC]

Ah, I thought that was intentional :O

[Comment 18 Evgeny Bobkin 2013-05-11 08:21:41 UTC]

Created attachment 347972 [details]
that is how it should look like in gnome-terminal

[Comment 19 Pacho Ramos 2013-05-11 08:51:28 UTC]

+*light-themes-0.1.93-r2 (11 May 2013)
+
+  11 May 2013; Pacho Ramos <[e-mail]>
+  +files/light-themes-0.1.93-gtk3.8-3.patch, +light-themes-0.1.93-r2.ebuild,
+  -light-themes-0.1.93-r1.ebuild:
+  Fix remaining gtk+-3.8 issue (#469062 by Evgeny Bobkin)
+