Summary: | mail-mta/exim: add systemd unit | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Alexander Tsoy <alexander> |
Component: | Current packages | Assignee: | Fabian Groffen <grobian> |
Status: | RESOLVED FIXED | ||
Severity: | enhancement | CC: | net-mail+disabled, pacho, systemd |
Priority: | Normal | Keywords: | PATCH |
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 448882 | ||
Attachments: |
exim-4.80.1.ebuild.patch
exim.service exim.logrotate.patch exim.service exim.service exim-4.80.1-r1.ebuild.patch |
Description
Alexander Tsoy
2013-05-04 22:54:59 UTC
Created attachment 347394 [details, diff]
exim-4.80.1.ebuild.patch
Created attachment 347396 [details]
exim.service
Created attachment 347400 [details, diff]
exim.logrotate.patch
Postrotate does not need for exim. RHEL and Debian doesn't have it in logrotate config too.
Created attachment 348840 [details]
exim.service
Improved systemd unit.
- changed command line option "-bd" -> "-bdf"
- added ExecReload option
I will commit in a week if nobody disagrees (also CCing systemd team to let them review the unit files) I'm fine with the systemd stuff (oneliner, and a file). The logrotate is probably fine, but really is unrelated to systemd support, IMO OK, regarding the logrotate issue, please open a separate bug report. Regarding unit file, I have just seen Arch is providing a lot of service files allowing probably a better experience, Alexander, could you take a look on them? https://projects.archlinux.org/svntogit/community.git/tree/trunk?h=packages/exim Thanks (In reply to Pacho Ramos from comment #7) exim.service - "PIDFile" option is not needed for Type=simple. - It's easier to override env variable QUEUE than the whole "ExecStart" (via /etc/systemd/system/exim.service.d/*.conf). So you can drop "Conflicts" option from my unit and it will be fine imho. exim-submission.socket exim-submission@.service exim.socket exim@.service These are for indetd-like socket activation. You can install them too. (In reply to Fabian Groffen from comment #6) > The logrotate is probably fine, but really is unrelated to systemd support, > IMO Current logrotate produces errors in systemd environment. (In reply to Alexander Tsoy from comment #9) > Current logrotate produces errors in systemd environment. Hmm.. Or may be I'm wrong (> /dev/null 2>&1 || true). Anyway I've opened a separate bug 477748. (In reply to Alexander Tsoy from comment #8) > (In reply to Pacho Ramos from comment #7) > > exim.service > > - "PIDFile" option is not needed for Type=simple. > - It's easier to override env variable QUEUE than the whole "ExecStart" > (via /etc/systemd/system/exim.service.d/*.conf). > > So you can drop "Conflicts" option from my unit and it will be fine imho. > > > exim-submission.socket > exim-submission@.service > exim.socket > exim@.service > > These are for indetd-like socket activation. You can install them too. I would appreciate if you could update attachments yet :) Thanks a lot Created attachment 354320 [details]
exim.service
Created attachment 354324 [details, diff]
exim-4.80.1-r1.ebuild.patch
+*exim-4.80.1-r2 (27 Jul 2013) + + 27 Jul 2013; Pacho Ramos <pacho@gentoo.org> +exim-4.80.1-r2.ebuild, + +files/exim-submission.socket, +files/exim-submission_at.service, + +files/exim.service, +files/exim.socket, +files/exim_at.service: + Install unit file #470754 by Alexander Tsoy + |