Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 468624 - mail-mta/exim: add systemd unit
Summary: mail-mta/exim: add systemd unit
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Fabian Groffen
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks: install-systemd-unit
  Show dependency tree
 
Reported: 2013-05-04 22:54 UTC by Alexander Tsoy
Modified: 2013-07-27 20:00 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
exim-4.80.1.ebuild.patch (exim-4.80.1.ebuild.patch,892 bytes, patch)
2013-05-04 22:55 UTC, Alexander Tsoy
Details | Diff
exim.service (exim.service,236 bytes, text/plain)
2013-05-04 22:56 UTC, Alexander Tsoy
Details
exim.logrotate.patch (exim.logrotate.patch,309 bytes, patch)
2013-05-04 23:01 UTC, Alexander Tsoy
Details | Diff
exim.service (exim.service,272 bytes, text/plain)
2013-05-21 17:26 UTC, Alexander Tsoy
Details
exim.service (exim.service,229 bytes, text/plain)
2013-07-27 15:17 UTC, Alexander Tsoy
Details
exim-4.80.1-r1.ebuild.patch (exim-4.80.1-r1.ebuild.patch,911 bytes, patch)
2013-07-27 15:32 UTC, Alexander Tsoy
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Tsoy 2013-05-04 22:54:59 UTC
Please add systemd support for exim.

Reproducible: Always
Comment 1 Alexander Tsoy 2013-05-04 22:55:33 UTC
Created attachment 347394 [details, diff]
exim-4.80.1.ebuild.patch
Comment 2 Alexander Tsoy 2013-05-04 22:56:18 UTC
Created attachment 347396 [details]
exim.service
Comment 3 Alexander Tsoy 2013-05-04 23:01:18 UTC
Created attachment 347400 [details, diff]
exim.logrotate.patch

Postrotate does not need for exim. RHEL and Debian doesn't have it in logrotate config too.
Comment 4 Alexander Tsoy 2013-05-21 17:26:50 UTC
Created attachment 348840 [details]
exim.service

Improved systemd unit.
 - changed command line option "-bd" -> "-bdf"
 - added ExecReload option
Comment 5 Pacho Ramos gentoo-dev 2013-07-20 13:17:19 UTC
I will commit in a week if nobody disagrees (also CCing systemd team to let them review the unit files)
Comment 6 Fabian Groffen gentoo-dev 2013-07-20 13:51:44 UTC
I'm fine with the systemd stuff (oneliner, and a file).

The logrotate is probably fine, but really is unrelated to systemd support, IMO
Comment 7 Pacho Ramos gentoo-dev 2013-07-20 14:12:51 UTC
OK, regarding the logrotate issue, please open a separate bug report. Regarding unit file, I have just seen Arch is providing a lot of service files allowing probably a better experience, Alexander, could you take a look on them?
https://projects.archlinux.org/svntogit/community.git/tree/trunk?h=packages/exim

Thanks
Comment 8 Alexander Tsoy 2013-07-22 13:26:48 UTC
(In reply to Pacho Ramos from comment #7)

exim.service

 - "PIDFile" option is not needed for Type=simple.
 - It's easier to override env variable QUEUE than the whole "ExecStart" (via /etc/systemd/system/exim.service.d/*.conf).

So you can drop "Conflicts" option from my unit and it will be fine imho.


exim-submission.socket
exim-submission@.service
exim.socket
exim@.service

These are for indetd-like socket activation. You can install them too.
Comment 9 Alexander Tsoy 2013-07-22 13:30:02 UTC
(In reply to Fabian Groffen from comment #6)

> The logrotate is probably fine, but really is unrelated to systemd support,
> IMO

Current logrotate produces errors in systemd environment.
Comment 10 Alexander Tsoy 2013-07-22 13:46:57 UTC
(In reply to Alexander Tsoy from comment #9)

> Current logrotate produces errors in systemd environment.

Hmm.. Or may be I'm wrong (> /dev/null 2>&1 || true). Anyway I've opened a separate bug 477748.
Comment 11 Pacho Ramos gentoo-dev 2013-07-27 07:15:44 UTC
(In reply to Alexander Tsoy from comment #8)
> (In reply to Pacho Ramos from comment #7)
> 
> exim.service
> 
>  - "PIDFile" option is not needed for Type=simple.
>  - It's easier to override env variable QUEUE than the whole "ExecStart"
> (via /etc/systemd/system/exim.service.d/*.conf).
> 
> So you can drop "Conflicts" option from my unit and it will be fine imho.
> 
> 
> exim-submission.socket
> exim-submission@.service
> exim.socket
> exim@.service
> 
> These are for indetd-like socket activation. You can install them too.

I would appreciate if you could update attachments yet :)

Thanks a lot
Comment 12 Alexander Tsoy 2013-07-27 15:17:01 UTC
Created attachment 354320 [details]
exim.service
Comment 13 Alexander Tsoy 2013-07-27 15:32:05 UTC
Created attachment 354324 [details, diff]
exim-4.80.1-r1.ebuild.patch
Comment 14 Pacho Ramos gentoo-dev 2013-07-27 20:00:25 UTC
+*exim-4.80.1-r2 (27 Jul 2013)
+
+  27 Jul 2013; Pacho Ramos <pacho@gentoo.org> +exim-4.80.1-r2.ebuild,
+  +files/exim-submission.socket, +files/exim-submission_at.service,
+  +files/exim.service, +files/exim.socket, +files/exim_at.service:
+  Install unit file #470754 by Alexander Tsoy
+