Bug 466340

Summary:	net-ftp/vsftpd: add systemd unit, move checkconfig() to /usr/libexec/vsftpd-checkconfig.sh
Product:	Gentoo Linux	Reporter:	Fabio Erculiani (RETIRED) <lxnay>
Component:	New packages	Assignee:	Gentoo's FTP Packages Maintainers <net-ftp>
Status:	RESOLVED FIXED
Severity:	normal	CC:	bugs, hwoarang, systemd, wired
Priority:	Normal	Keywords:	REVIEWED
Version:	unspecified
Hardware:	All
OS:	Linux
URL:	https://github.com/Sabayon/systemd-love/tree/master/net-ftp/vsftpd
See Also:	https://bugs.gentoo.org/show_bug.cgi?id=467410
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	vsftpd init script diff vsftpd ebuild diff vsftpd systemd unit vsftpd-checkconfig.sh

Description Fabio Erculiani (RETIRED) gentoo-dev

2013-04-18 10:34:44 UTC

At URL I committed an ebuild that adds a working systemd unit for net-ftp/vsftpd.
I moved the checkconfig() part of the openrc init script to /usr/libexec/vsftpd-checkconfig.sh to be reusable by the systemd unit.

Please have a look at the attached diffs.

Reproducible: Always

Comment 1 Fabio Erculiani (RETIRED) gentoo-dev

2013-04-18 10:35:05 UTC

Created attachment 345874 [details, diff]
vsftpd init script diff

Comment 2 Fabio Erculiani (RETIRED) gentoo-dev

2013-04-18 10:35:20 UTC

Created attachment 345876 [details, diff]
vsftpd ebuild diff

Comment 3 Fabio Erculiani (RETIRED) gentoo-dev

2013-04-18 10:35:49 UTC

Created attachment 345878 [details]
vsftpd systemd unit

Comment 4 Markos Chandras (RETIRED) gentoo-dev

2013-04-18 10:42:23 UTC

Patches look good to me. Feel free to commit them

Comment 5 Johan Bergström 2013-04-18 10:43:39 UTC

LGTM too

Comment 6 Markos Chandras (RETIRED) gentoo-dev

2013-04-20 12:05:42 UTC

The usr/libexec/vsftpd-checkconfig.sh is missing. Can we have that too?

Comment 7 Fabio Erculiani (RETIRED) gentoo-dev

2013-04-20 12:16:11 UTC

Created attachment 346082 [details]
vsftpd-checkconfig.sh

It's on the overlay under FILESDIR however

Comment 8 Markos Chandras (RETIRED) gentoo-dev

2013-04-20 16:49:21 UTC

+*vsftpd-3.0.2-r1 (20 Apr 2013)
+
+  20 Apr 2013; Markos Chandras <hwoarang@gentoo.org> +vsftpd-3.0.2-r1.ebuild,
+  +files/vsftpd-3.0.2-remove-legacy-cap.patch, +files/vsftpd.service,
+  +files/vsftpd-checkconfig.sh, files/vsftpd.init:
+  Add systemd unit file. Bug #466340 thanks to Fabio Erculiani
+  <lxnay@gentoo.org>. Add patch to remove legacy capabilities by
+  Joakim Tjernlund <Joakim.Tjernlund@transmode.se>. Bug #450536
+

Comment 9 Fabio Erculiani (RETIRED) gentoo-dev

2013-04-20 16:52:21 UTC

Thanks!