Bug 459678

Summary:	cmake-utils.eclass: please consider dropping 'base' inherit and EAPI<2 support
Product:	Gentoo Linux	Reporter:	Michał Górny <mgorny>
Component:	Eclasses	Assignee:	Gentoo KDE team <kde>
Status:	RESOLVED FIXED
Severity:	enhancement	CC:	erikdenstore+gbugs
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:	460572
Bug Blocks:

Description Michał Górny archtester

2013-02-28 09:08:58 UTC

base.eclass is broken by design and exports src_unpack() in every EAPI, making it hard to work with VCS eclasses and is generally a very bad practice.

Please consider dropping the inherit and inlining the necessary logic in cmake-utils_src_prepare(). Dropping EAPI<2 support (it is used just by a few ebuilds) would probably be doable at the same time.

Comment 1 Michael Palimaka (kensington) gentoo-dev

2013-02-28 14:11:06 UTC

Yes please!

Comment 2 Andreas K. Hüttel archtester

2013-03-06 07:40:27 UTC

+1

Comment 3 Chris Reffett (RETIRED) gentoo-dev

2013-04-16 15:34:57 UTC

A testing version of this is in the KDE overlay.

Comment 4 Michael Palimaka (kensington) gentoo-dev

2013-06-27 18:22:05 UTC

July is coming up, I guess the last thing to do is to check if any packages inheriting cmake-utils call base_* without explicitly inheriting.

Comment 5 Chris Reffett (RETIRED) gentoo-dev

2013-07-02 13:38:17 UTC

Committed the change last night.