| Summary: | app-admin/collectd-5.2.1 version bump | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Johan Bergström <bugs> |
| Component: | New packages | Assignee: | Proxy Maintainers <proxy-maint> |
| Status: | RESOLVED FIXED | ||
| Severity: | enhancement | CC: | whissi |
| Priority: | Normal | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Bug Depends on: | |||
| Bug Blocks: | 458386 | ||
| Attachments: |
collectd-5.2.1.ebuild
build.log from building collectd without perl |
||
|
Description
Johan Bergström
2013-01-29 21:44:16 UTC
Created attachment 340900 [details] collectd-5.2.1.ebuild Here's an updated ebuild. Commitdiff here: https://github.com/jbergstroem/gentoo-overlay/compare/collectd-5.2.1 (I also removed the rm *.a line since there was no files to remove.) +*collectd-5.2.1 (05 Mar 2013) + + 05 Mar 2013; Markos Chandras <hwoarang@gentoo.org> +collectd-5.2.1.ebuild: + Version bump. #454594. Thanks to Johan Bergström <bugs@bergstroem.nu> + It seems like building without perl can bail in some setups (found this just now) during the configure phase. Sorry for not finding it in time, Markos.
Here's a diff that fixes is:
--- /usr/portage/app-admin/collectd/collectd-5.2.1.ebuild 2013-03-06 08:26:50.000000000 +1100
+++ collectd-5.2.1.ebuild 2013-03-06 14:20:26.728959748 +1100
@@ -289,7 +289,11 @@
fi
# The perl bindings
- myconf+=" $(use_with perl perl-bindings=INSTALLDIRS=vendor)"
+ if use perl; then
+ myconf+=" --with-perl-bindings=INSTALLDIRS=vendor"
+ else
+ myconf+=" --without-perl-bindings"
+ fi
# Finally, run econf.
KERNEL_DIR="${KERNEL_DIR}" econf --config-cache --without-included-ltdl $(use_enable static-libs static) --localstatedir=/var ${myconf}
Do you think we should -r1?
Created attachment 341090 [details] build.log from building collectd without perl (In reply to comment #3) > Do you think we should -r1? Would be nice (at least update the ebuild) - I am affected by this problem: configure: error: invalid package name: perl-bindings=INSTALLDIRS=vendor (In reply to comment #3) > It seems like building without perl can bail in some setups (found this just > now) during the configure phase. Sorry for not finding it in time, Markos. > > Here's a diff that fixes is: > --- /usr/portage/app-admin/collectd/collectd-5.2.1.ebuild 2013-03-06 > 08:26:50.000000000 +1100 > +++ collectd-5.2.1.ebuild 2013-03-06 14:20:26.728959748 +1100 > @@ -289,7 +289,11 @@ > fi > > # The perl bindings > - myconf+=" $(use_with perl perl-bindings=INSTALLDIRS=vendor)" > + if use perl; then > + myconf+=" --with-perl-bindings=INSTALLDIRS=vendor" > + else > + myconf+=" --without-perl-bindings" > + fi > > # Finally, run econf. > KERNEL_DIR="${KERNEL_DIR}" econf --config-cache --without-included-ltdl > $(use_enable static-libs static) --localstatedir=/var ${myconf} > > > Do you think we should -r1? No need for -r1. I presume those who hit this problem will not be able to configure/build the package. I will update the ebuild tonight. + 06 Mar 2013; Markos Chandras <hwoarang@gentoo.org> collectd-5.2.1.ebuild: + Fix building without perl + |