Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 452544

Summary: Old vlan flags syntax isn't handled correctly
Product: Gentoo Hosted Projects Reporter: vitalyb
Component: OpenRCAssignee: OpenRC Team <openrc>
Status: RESOLVED FIXED    
Severity: normal CC: ruslanpisarev
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 439098    

Description vitalyb 2013-01-16 12:49:27 UTC
Hello,

there's a typo in net/vlan.sh script which breaks backward compatibility for vlan flags:

--- vlan.sh.orig	2013-01-03 10:28:39.000000000 +0200
+++ vlan.sh	2013-01-16 14:44:51.000000000 +0200
@@ -71,7 +71,7 @@
 		[ -z "${vname}" ] && vname="${IFACE}.${vlan}"
 		# 2) flags
 		eval vflags=\$${IFACE}_vlan${vlan}_flags
-		[ -z "${vname}" ] && eval vflags=\$vlan${vlan}_flags
+		[ -z "${vflags}" ] && eval vflags=\$vlan${vlan}_flags
 		# 3) ingress/egress map
 		eval vingress=\$${IFACE}_vlan${vlan}_ingress
 		[ -z "${vingress}" ] && eval vingress=\$vlan${vlan}_ingress
Comment 1 rpisarev 2013-01-16 12:58:11 UTC
Hey.
Also saw that.

Сonfigs updated manually.
Comment 2 William Hubbs gentoo-dev 2013-02-17 21:42:08 UTC
 this is fixed in commit f36f8fb and will be in openrc-0.12.

report.
I don't understand the meaning of comment #1, but it looks like a
separate issue, so please open another bug.

Thanks,

William