Summary: | app-portage/genlop: bashcomp script fails when make.conf is in /etc/portage/ | ||
---|---|---|---|
Product: | Portage Development | Reporter: | Mira Ressel <aranea> |
Component: | Tools | Assignee: | Portage Tools Team <tools-portage> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | bugs-gentoo, fuzzyray, kevinlyles, kingjon3377, prote, wonko |
Priority: | Normal | Keywords: | PATCH |
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
See Also: | https://bugs.gentoo.org/show_bug.cgi?id=424777 | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
Patch for /usr/share/bash-completion/genlop
Proposed patch for genlop's bashcomp script Similar patch |
See also #424777 , but I don't have permission to add that to the "See-Also"-field. Created attachment 325614 [details, diff]
Proposed patch for genlop's bashcomp script
As Jeroen pointed out, my patch is far from optimal, so let's do it the simple way...
*** Bug 439234 has been marked as a duplicate of this bug. *** Created attachment 330418 [details, diff]
Similar patch
I would replace the old location entirely, because otherwise pressing <Tab> causes error messages to appear in the shell. Also, should not /etc/make.globals also be changed to /usr/share/portage/config/make.globals?
*** Bug 447058 has been marked as a duplicate of this bug. *** ping rubik's cube, yes. I made a symlink to the actual make.globals in /etc for the time being, because if not, when using tab the entire shell gets screwed up. $ fgrep -n make.globals /usr/share/bash-completion/completions/genlop 19: portagedir="$( (source /etc/make.globals Needs to be /usr/share/portage/config/make.globals Fixed in 2013: https://github.com/gentoo-perl/genlop/commit/ccc1e712015d12ac0e74802ef9d126fecdb055ef *** Bug 651070 has been marked as a duplicate of this bug. *** |
Created attachment 323406 [details, diff] Patch for /usr/share/bash-completion/genlop If make.conf is in /etc/portage/ instead of /etc/ (portage supports that, and since today it is default for new stage3s), genlop's bash-completion script doesn't work. A patch is attached.