| Summary: | sys-devel/pmake: please review prefix changes | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Christoph Junghans (RETIRED) <junghans> |
| Component: | [OLD] Core system | Assignee: | Gentoo/BSD Team <bsd+disabled> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | prefix |
| Priority: | Normal | Keywords: | Inclusion, InVCS, PATCH |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Bug Depends on: | |||
| Bug Blocks: | 315803 | ||
| Attachments: | patch for pmake-1.111.3.1.ebuild | ||
hmmm it is a system package on g/fbsd, so it is not the best idea to use greatest and latest eapi there. can you please make it use eapi3 instead ? just so that upgrade path is not too broken (In reply to comment #1) > hmmm it is a system package on g/fbsd, so it is not the best idea to use > greatest and latest eapi there. can you please make it use eapi3 instead ? > just so that upgrade path is not too broken scrap that... it seems what we use on g/fbsd is bundled in the freebsd-* ebuilds... patch ok then :) (In reply to comment #3) > patch ok then :) Commit in-place or as -r1 ? (I can also make it EAPI=3 as the only difference will be to keep the "|| die" statements.) (In reply to comment #4) > (In reply to comment #3) > > patch ok then :) > > Commit in-place or as -r1 ? in-place should be fine > (I can also make it EAPI=3 as the only difference will be to keep the "|| > die" statements.) eapi 4 is fine, it seems i need more coffee these days :) Done, thanks. |
Created attachment 323364 [details, diff] patch for pmake-1.111.3.1.ebuild Changes: - EAPI bumped to 4 to make portage prefix aware - added two additional CFLAGS - helpers die automatically on EAPI=4