Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 434530 - sys-devel/pmake: please review prefix changes
Summary: sys-devel/pmake: please review prefix changes
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Core system (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo/BSD Team
URL:
Whiteboard:
Keywords: Inclusion, InVCS, PATCH
Depends on:
Blocks: prefix-gx86
  Show dependency tree
 
Reported: 2012-09-10 03:41 UTC by Christoph Junghans (RETIRED)
Modified: 2012-09-11 01:31 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
patch for pmake-1.111.3.1.ebuild (pmake-1.111.3.1.ebuild.patch,1.69 KB, patch)
2012-09-10 03:41 UTC, Christoph Junghans (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Christoph Junghans (RETIRED) gentoo-dev 2012-09-10 03:41:36 UTC
Created attachment 323364 [details, diff]
patch for pmake-1.111.3.1.ebuild

Changes:
- EAPI bumped to 4 to make portage prefix aware
- added two additional CFLAGS
- helpers die automatically on EAPI=4
Comment 1 Alexis Ballier gentoo-dev 2012-09-10 11:24:09 UTC
hmmm it is a system package on g/fbsd, so it is not the best idea to use greatest and latest eapi there. can you please make it use eapi3 instead ? just so that upgrade path is not too broken
Comment 2 Alexis Ballier gentoo-dev 2012-09-10 11:25:07 UTC
(In reply to comment #1)
> hmmm it is a system package on g/fbsd, so it is not the best idea to use
> greatest and latest eapi there. can you please make it use eapi3 instead ?
> just so that upgrade path is not too broken

scrap that... it seems what we use on g/fbsd is bundled in the freebsd-* ebuilds...
Comment 3 Alexis Ballier gentoo-dev 2012-09-10 11:25:54 UTC
patch ok then :)
Comment 4 Christoph Junghans (RETIRED) gentoo-dev 2012-09-10 15:09:31 UTC
(In reply to comment #3)
> patch ok then :)

Commit in-place or as -r1 ?

(I can also make it EAPI=3 as the only difference will be to keep the "|| die" statements.)
Comment 5 Alexis Ballier gentoo-dev 2012-09-10 15:31:14 UTC
(In reply to comment #4)
> (In reply to comment #3)
> > patch ok then :)
> 
> Commit in-place or as -r1 ?

in-place should be fine

> (I can also make it EAPI=3 as the only difference will be to keep the "||
> die" statements.)

eapi 4 is fine, it seems i need more coffee these days :)
Comment 6 Christoph Junghans (RETIRED) gentoo-dev 2012-09-11 01:31:36 UTC
Done, thanks.