Summary: | games-strategy/vcmi-0.89.ebuild - a free HOMM 3 clone | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Weihua Zhou <zhouwh> |
Component: | New packages | Assignee: | Default Assignee for New Packages <maintainer-wanted> |
Status: | UNCONFIRMED --- | ||
Severity: | enhancement | CC: | ansla80, games, jstein, Sergiy.Borodych |
Priority: | Normal | Keywords: | EBUILD, PATCH |
Version: | unspecified | ||
Hardware: | AMD64 | ||
OS: | Linux | ||
URL: | http://forum.vcmi.eu/portal.php | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | 424191 | ||
Bug Blocks: | |||
Attachments: |
The ebuild for vcmi 0.89 version
The patch file for compiling under gcc 4.5 The svn version of vcmi Add eautoreconf in src_prepare to avoid QA Notice The svn version of vcmi The ebuild for vcmi 0.89 version Ebuild for 0.96 and live git versions |
Description
Weihua Zhou
2012-06-30 03:47:00 UTC
I've been trying to post the patch file here but with no luck yet. Maybe you will need to wait for a while for my network to work. Created attachment 316937 [details, diff]
The patch file for compiling under gcc 4.5
Just put this patch file under files directory and the ebuild should work.
Created attachment 316939 [details]
The svn version of vcmi
Created attachment 318592 [details]
Add eautoreconf in src_prepare to avoid QA Notice
Created attachment 318594 [details]
The svn version of vcmi
Add eautoreconf in src_prepare to avoid QA Notice
Created attachment 318596 [details]
The ebuild for vcmi 0.89 version
I just found I uploaded a wrong one, this one should be correct.
- patch fails here. - dropbox url is not reliable imo. Use something like googlecode or github download section - visual style can be improved, too many newlines, do something like this: EAPI=4 inherit eutils games autotools DESCRIPTION="" HOMEPAGE="" SRC_URI="" LICENSE="" SLOT="" KEYWORDS="" IUSE="" RESTRICT="" RDEPEND="" DEPEND="" - is there a minimum boost version? (often the case, look at configure.ac) - no useflag deps for ffmpeg, libsdl, sdl-image and sdl-mixer? - no period at end of description - RDEPEND="${DEPEND}" <- that is a silly line imo, although it's standard for the vim-skeleton and such. Even if it's correct in a particular case this often leads to people adding things like "pkgconfig" to runtime-dependencies. The cleanest way is to have 3 types of dependencies... runtime-only (RDEPEND), buildtime-only (DEPEND) and build/run-time deps (COMMON_DEPEND) that would lead to something like this COMMON_DEPEND="..." RDEPEND="${COMMON_DEPEND} ..." DEPEND="${COMMON_DEPEND}..." since you often don't have runtime-only deps you can simply do RDEPEND="..." DEPEND="${RDEPEND} ..." ...means: you start with runtime deps. - virtual/pkgconfig missing from DEPEND - inherit games eclass always last (this will please the games herd) - FILESDIR variable must be quoted. - do not sed on Makefile.in - desktopdir does not need any fix afais - if you fix icondir, do it right and change the destination to an appropriate subdir like: icondir = $(datadir)/icons/hicolor/64x64/apps Then you have to update the icon cache via gnome2-utils like: pkg_preinst() { games_pkg_preinst gnome2_icon_savelist } pkg_postinst() { games_pkg_postinst gnome2_icon_cache_update } pkg_postrm() { gnome2_icon_cache_update } - "prepgamesdirs" is completely missing. package disrespects CFLAGS/CXXFLAGS Created attachment 380392 [details]
Ebuild for 0.96 and live git versions
Here is new ebuild.
VCMI optionally depends on qt:5 packages (available in qt overlay) when editor or launcher flags used.
|