Bug 421671

Summary:	app-editors/nvi: db44 patch is half-broken
Product:	Gentoo Linux	Reporter:	Diego Elio Pettenò (RETIRED) <flameeyes>
Component:	New packages	Assignee:	Jesus Rivero (RETIRED) <neurogeek>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	319587

Description Diego Elio Pettenò (RETIRED) gentoo-dev

2012-06-17 22:39:47 UTC

I fixed the QA notices on the patches with ../ in them since I saw it on the tinderbox. On the other hand I'd like for you to review/fix the db44 patch which has broken logic:

major >= 4 minor >= 4

will hit 4.4, 4.[5-9], 5.[4-9], 6.[4-9]

else major >= 1 minor >=1

will hit 4.[1-3], 5.[1-3], 6.[1-3]

what you want is

(major == 4 && minor >= 4) || major > 4
else major == 4 && minor >= 1

which will do what you expect.

Comment 1 Jesus Rivero (RETIRED) gentoo-dev

2012-08-27 15:48:40 UTC

This one was just pushed to the tree. 
Thanks Diego.