Bug 417535

Summary:	unclear statement about binary files in gentoo-x86
Product:	Documentation	Reporter:	Julian Ospald <hasufell>
Component:	[OLD] Developer Handbook	Assignee:	Gentoo Community Relations Team <comrel>
Status:	RESOLVED INVALID
Severity:	normal
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
URL:	http://www.gentoo.org/proj/en/devrel/handbook/handbook.xml?part=2&chap=1
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	hb-guide-ebuild.xml.patch

Description Julian Ospald 2012-05-26 00:45:23 UTC

The handbook says binaries should not be added to the portage tree (introduced by bug https://bugs.gentoo.org/show_bug.cgi?id=331331 )
However it also says they can be added if you use "cvs add -kb myphoto.png".

From the discussion in bug https://bugs.gentoo.org/show_bug.cgi?id=417117 it seems they should _NEVER_ be added. If so, this is a documentation bug and should be clarified.

Comment 1 Julian Ospald 2012-05-26 01:08:41 UTC

It seems I didn't read closely enough, cause it says:
"If you need to do this in another CVS tree"

However I think this can potentially lead to misunderstanding, especially because the following cvs command is shown in nice color with the title "Adding binary files to CVS".

Comment 2 Samuli Suominen (RETIRED) gentoo-dev

2012-05-26 07:36:51 UTC

The text could be moved into it's own /green "note" box/ to stand out more. 
If you really want to pursue this, provide a patch.

Comment 3 Julian Ospald 2012-05-26 18:25:34 UTC

Created attachment 313165 [details, diff]
hb-guide-ebuild.xml.patch

I just removed the example and notes about how to add binary files to (other) CVS cause this is not a general guide to CVS commands and can lead to confusion.

I find this cleaner.

Comment 4 Samuli Suominen (RETIRED) gentoo-dev

2012-05-27 07:18:59 UTC

-1.  The snippet about adding binary files is useful for the gentoo/ tree, but not the gentoo-x86/ tree.

Comment 5 Markos Chandras (RETIRED) gentoo-dev

2012-05-27 09:56:20 UTC

Yes that is true. Other cvs trees (docs/ etc) can have binary files. That paragraph is clear enough that no binary files are allowed in gentoo-x86

Comment 6 Julian Ospald 2012-05-27 13:22:48 UTC

I disagree, because this is the EBUILD HOWTO and hence only deals with gentoo-x86 and there no binaries are allowed at all.

That would rather have a place in
http://www.gentoo.org/doc/en/cvs-tutorial.xml

but not here.

Comment 7 Markos Chandras (RETIRED) gentoo-dev

2012-05-27 14:55:48 UTC

I don't see how to make it more clear:

"Also, you should not add binary (non-ASCII) files to the
Portage CVS tree". There is nothing to fix here.