| Summary: | games-action/cs2d: Binary file cs2d.png in gentoo-x86 | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Samuli Suominen (RETIRED) <ssuominen> |
| Component: | Current packages | Assignee: | Maxim Koltsov (RETIRED) <maksbotan> |
| Status: | RESOLVED FIXED | ||
| Severity: | QA | CC: | games, oleg, proxy-maint |
| Priority: | Normal | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Bug Depends on: | |||
| Bug Blocks: | 331331 | ||
|
Description
Samuli Suominen (RETIRED)
2012-05-22 15:15:06 UTC
The ebuild looks to be in a bit poor shape too: 1. Was this reviewed at #gentoo-games and accepted for commit? 2. Why is games@ missing from metadata.xml? Please familiarize yourself with this document: http://dev.gentoo.org/~vapier/i-wanna-be-in-the-games-herd.html As far as I am informed you don't need review if you don't add the games herd to metadata.xml, but then you cannot expect them to participate in maintainenance. I suppose I can file a separate bug for each problem in the ebuild, but that just seems a lot of unnecessary work and getting it reviewed would be a lot easier. Last time I checked, games should always have games@gentoo.org in metadata.xml I myself always go through #gentoo-games and people there are relatively responsive, but I don't see an official note that this is a REQUIREMENT. Was there a council vote or something? Maintaining a single package completely on your own should be allowed afaik. Plz correct me if this is wrong. Also: http://www.gentoo.org/proj/en/devrel/handbook/handbook.xml?part=2&chap=1 this says it IS allowed to add .png if you use "cvs add -kb myphoto.png". If this is not correct then it's a documentation bug. However I would also suggest to drop by at #gentoo-games to work with the games herd. More maintainers/eyes means higher quality. (In reply to comment #5) > I myself always go through #gentoo-games and people there are relatively > responsive, but I don't see an official note that this is a REQUIREMENT. Was > there a council vote or something? Maintaining a single package completely > on your own should be allowed afaik. Plz correct me if this is wrong. > > Also: > http://www.gentoo.org/proj/en/devrel/handbook/handbook.xml?part=2&chap=1 > this says it IS allowed to add .png if you use "cvs add -kb myphoto.png". If > this is not correct then it's a documentation bug. > > However I would also suggest to drop by at #gentoo-games to work with the > games herd. More maintainers/eyes means higher quality. Err this is not something Council has to deal with. The council does not interferes with projects. However, I remember people saying that games@ must have explicit control over the games ebuilds. If this is not the case anymore then I apologize. And yes, the documentation is wrong. binary files must not be allowed in portage. Feel free to open a new bug about that and attach a patch so we can fix it (In reply to comment #5) > Also: > http://www.gentoo.org/proj/en/devrel/handbook/handbook.xml?part=2&chap=1 > this says it IS allowed to add .png if you use "cvs add -kb myphoto.png". If > this is not correct then it's a documentation bug. If you read the lines closely it says "you should not add binary files to the Portage CVS tree" and then gives the option you mention when doing so for other CVS repos. To me this means no binary files in the Portage tree, but they are allowed in other Gentoo CVS repos such as gentoo/misc/dev-pics. It could be clarified better though. (In reply to comment #7) > (In reply to comment #5) > > Also: > > http://www.gentoo.org/proj/en/devrel/handbook/handbook.xml?part=2&chap=1 > > this says it IS allowed to add .png if you use "cvs add -kb myphoto.png". If > > this is not correct then it's a documentation bug. > > If you read the lines closely it says "you should not add binary files to > the Portage CVS tree" and then gives the option you mention when doing so > for other CVS repos. > > To me this means no binary files in the Portage tree, but they are allowed > in other Gentoo CVS repos such as gentoo/misc/dev-pics. It could be > clarified better though. for that discussion I opened: https://bugs.gentoo.org/show_bug.cgi?id=417535 The current documentation is very clear on the "If you need to do this in another CVS tree" -part, it has no room for confusion Fixed by move of png to mirrors. |