Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 416739

Summary: games-mods.eclass uses deprecated $PORTDIR variable
Product: Gentoo Linux Reporter: Michał Górny <mgorny>
Component: EclassesAssignee: Gentoo Games <games>
Status: RESOLVED FIXED    
Severity: major CC: qa, treecleaner, tristan
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
See Also: https://bugs.gentoo.org/show_bug.cgi?id=574642
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 373349    

Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2012-05-20 14:16:29 UTC
Considering that $PORTDIR may be removed in a future EAPI, please consider removing its use from the eclass.

Please also note that the eclass lacks any maintainership information...
Comment 1 Mike Gilbert gentoo-dev 2012-05-21 02:07:18 UTC
Eclass has no maintainer listed; sending it to games as that seems the obvious choice.

Also CC'd tristan, formerly known as nyhm.
Comment 2 Mr. Bones. (RETIRED) gentoo-dev 2012-05-27 21:13:14 UTC
PORTDIR isn't deprecated.  When it is, reopen.
Comment 3 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2017-09-03 14:21:24 UTC
Given that the eclass is horrible and completely unmaintained, it might be better to just lastrite all the mods that people don't want to maintain directly.

The complete list is:

games-fps/doom3-cdoom
games-fps/doom3-chextrek
games-fps/doom3-ducttape
games-fps/doom3-eventhorizon
games-fps/doom3-hellcampaign
games-fps/doom3-inhell
games-fps/doom3-lms
games-fps/doom3-mitm
games-fps/enemy-territory-etpro
games-fps/enemy-territory-omnibot
games-fps/enemy-territory-truecombat
games-fps/quake3-alliance
games-fps/quake3-alternatefire
games-fps/quake3-bfp
games-fps/quake3-cpma
games-fps/quake3-defrag
games-fps/quake3-excessiveplus
games-fps/quake3-lrctf
games-fps/quake3-matrix
games-fps/quake3-nsco
games-fps/quake3-osp
games-fps/quake3-ra3
games-fps/quake3-reaction
games-fps/quake3-ruinhunters
games-fps/quake3-threewave
games-fps/ut2004-action
games-fps/ut2004-airbuccaneers
games-fps/ut2004-bonuspack-cbp1
games-fps/ut2004-bonuspack-cbp2
games-fps/ut2004-bonuspack-ece
games-fps/ut2004-bonuspack-mega
games-fps/ut2004-cor
games-fps/ut2004-crossfire
games-fps/ut2004-deathball
games-fps/ut2004-fragops
games-fps/ut2004-hamsterbash
games-fps/ut2004-muralis
games-fps/ut2004-strikeforce
games-fps/ut2004-troopers
games-fps/ut2004-unwheel
Comment 4 Ulrich Müller gentoo-dev 2017-09-03 15:41:08 UTC
Actually this was trivial to fix.

-$(head -n 2 ${PORTDIR}/header.txt)
+# Copyright 1999-2016 Gentoo Foundation
+# Distributed under the terms of the GNU General Public License v2

The code of the init script in games-mods_make_initd() was last touched in 2016, therefore it is that end year. (Automatically updating from header.txt was even wrong, since you cannot claim copyright for a year where there were no changes.)