Bug 415805

Summary:	mozcoreconf-2 eclass should filter MOZCONFIG env variable in moz_pkgsetup()
Product:	Gentoo Linux	Reporter:	Julian Simioni <julian>
Component:	Eclasses	Assignee:	Mozilla Gentoo Team <mozilla>
Status:	RESOLVED FIXED
Severity:	minor	CC:	arfrever.fta
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	Patch to filter MOZCONFIG

Description Julian Simioni 2012-05-13 21:58:06 UTC

If doing development on any of the Mozilla applications, it's possible a user will set the MOZCONFIG[1] environmental variable to use their own developer settings. 
Even if no special settings are configured, the mere existence of this env var, if picked up during a compile of an ebuild such as Firefox or Thunderbird, can affect the result. In my case it simply caused Firefox to use the "Nightly" branding, but this is still undesirable.

Filtering MOZCONFIG in moz_pkgsetup() should eliminate any chance of this happening.

[1] Example of how MOZCONFIG is used: https://developer.mozilla.org/En/Developer_Guide/Source_Code/Mercurial

Comment 1 Julian Simioni 2012-05-24 01:55:40 UTC

Created attachment 312909 [details]
Patch to filter MOZCONFIG

To speed things along, here's a patch that I tested in an overlay. It successfully ensures that firefox builds in a "clean" environment regardless of user env settings.

Comment 2 Jory A. Pratt gentoo-dev

2013-08-26 14:40:38 UTC

Thanks for reporting. I have pushed to overlay, and tree.

Comment 3 Arfrever Frehtes Taifersar Arahesis 2013-08-26 22:21:30 UTC

eval is not needed here.