Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 409969

Summary: app-shells/fish doesn't honor LINGUAS for locale files
Product: Gentoo Linux Reporter: Piotr Szymaniak <bugzie>
Component: Current packagesAssignee: Georgy Yakovlev <gyakovlev>
Status: RESOLVED FIXED    
Severity: normal CC: polynomial-c
Priority: Normal Keywords: NeedPatch
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 405485    

Description Piotr Szymaniak 2012-03-28 09:07:34 UTC
When sys-apps/lshw-02.16b is emerged, it dumps LC_MESSAGES for fr, whereas I have the line 'LINGUAS="en pl"' in  make.conf.

Actual Results:  
LC_MESSAGES contains unwanted file

Expected Results:  
LC_MESSAGES should contain only files for selected LINGUAS


/usr/share/locale/de/LC_MESSAGES/fish.mo
/usr/share/locale/en/LC_MESSAGES/fish.mo
/usr/share/locale/fr/LC_MESSAGES/fish.mo
/usr/share/locale/sv/LC_MESSAGES/fish.mo
Comment 1 Georgy Yakovlev archtester gentoo-dev 2017-02-21 21:49:07 UTC
I've open upstream issue for this to see if fish developers are willing to work on it from their side.
https://github.com/fish-shell/fish-shell/issues/3863

It's possible to hack ebuild and remove the messages, but gentoo is moving away from having ebuilds bake in LINGUAS support, unless the build system supports it implicitly.

let's wait and see what upstream says.
Comment 2 Georgy Yakovlev archtester gentoo-dev 2017-02-23 04:06:35 UTC
my fix got merged upstream.
https://github.com/fish-shell/fish-shell/commit/b2174bc9c00733856f5d8dac901edbffcbd79829

so fish will honor LINGUAS as of version 2.6.0 which is scheduled to be available sometime in Apr or May 2017.

Maybe I'll backport a patch to 2.5.0.
Comment 3 Georgy Yakovlev archtester gentoo-dev 2017-03-03 19:58:20 UTC
From 0ab0eccf1cba817194be494894987b02337eef3f Mon Sep 17 00:00:00 2001
From: Georgy Yakovlev <ya@sysdump.net>
Date: Thu, 23 Feb 2017 22:34:59 -0800
Subject: [PATCH] app-shells/fish: add nls support

This adds nls useflag and includes
backported upstream patch to honor LINGUAS.
Fixes bug 409969.
Closes: https://github.com/gentoo/gentoo/pull/4072
---