Summary: | media-sound/easytag-2.1.7-r1: compilation fails with =media-libs/libmp4v2-1.9.1_p479 | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Lars Wendler (Polynomial-C) (RETIRED) <polynomial-c> |
Component: | Current packages | Assignee: | Gentoo Sound Team <sound> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | b.brachaczek, bugzie, casta, chewi, chris, fcoiffie, gentoo-bugs, giovanni.bobbio, kdvgent, kripton, leonidp.lists, mail, mgierok, mrueg, nbowler, olivier, optiluca, root, tetromino, transacid, zeekec |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
build.log
Not backwards compatible and unfinished patch Not backwards compatible libmp4v2_r479 patch |
Description
Lars Wendler (Polynomial-C) (RETIRED)
2012-03-22 08:55:55 UTC
Same issue here. Created attachment 306307 [details, diff]
Not backwards compatible and unfinished patch
This solves the errors in the build.log attached but it still later fails:
mp4_tag.o: In function `Mp4tag_Read_File_Tag':
mp4_tag.c:(.text+0x66): undefined reference to `MP4GetMetadataName'
mp4_tag.c:(.text+0x74): undefined reference to `MP4GetMetadataArtist'
mp4_tag.c:(.text+0x82): undefined reference to `MP4GetMetadataAlbum'
mp4_tag.c:(.text+0x96): undefined reference to `MP4GetMetadataDisk'
mp4_tag.c:(.text+0xda): undefined reference to `MP4GetMetadataYear'
mp4_tag.c:(.text+0xee): undefined reference to `MP4GetMetadataTrack'
mp4_tag.c:(.text+0x104): undefined reference to `MP4GetMetadataGenre'
mp4_tag.c:(.text+0x112): undefined reference to `MP4GetMetadataComment'
mp4_tag.c:(.text+0x120): undefined reference to `MP4GetMetadataWriter'
mp4_tag.c:(.text+0x12e): undefined reference to `MP4GetMetadataTool'
mp4_tag.c:(.text+0x17b): undefined reference to `MP4GetMetadataCoverArt'
mp4_tag.o: In function `Mp4tag_Write_File_Tag':
mp4_tag.c:(.text+0x36b): undefined reference to `MP4SetMetadataName'
mp4_tag.c:(.text+0x39e): undefined reference to `MP4SetMetadataArtist'
mp4_tag.c:(.text+0x3d1): undefined reference to `MP4SetMetadataAlbum'
mp4_tag.c:(.text+0x479): undefined reference to `MP4SetMetadataDisk'
mp4_tag.c:(.text+0x4ac): undefined reference to `MP4SetMetadataYear'
mp4_tag.c:(.text+0x50e): undefined reference to `MP4SetMetadataTrack'
mp4_tag.c:(.text+0x541): undefined reference to `MP4SetMetadataGenre'
mp4_tag.c:(.text+0x574): undefined reference to `MP4SetMetadataComment'
mp4_tag.c:(.text+0x5a7): undefined reference to `MP4SetMetadataWriter'
mp4_tag.c:(.text+0x5da): undefined reference to `MP4SetMetadataTool'
mp4_tag.c:(.text+0x5e8): undefined reference to `MP4SetMetadataCoverArt'
mp4_tag.c:(.text+0x61c): undefined reference to `MP4SetMetadataCoverArt'
mp4_tag.c:(.text+0x65b): undefined reference to `MP4SetMetadataName'
mp4_tag.c:(.text+0x673): undefined reference to `MP4SetMetadataTool'
mp4_tag.c:(.text+0x68b): undefined reference to `MP4SetMetadataWriter'
mp4_tag.c:(.text+0x6a3): undefined reference to `MP4SetMetadataComment'
mp4_tag.c:(.text+0x6bb): undefined reference to `MP4SetMetadataGenre'
mp4_tag.c:(.text+0x6d3): undefined reference to `MP4SetMetadataYear'
mp4_tag.c:(.text+0x6eb): undefined reference to `MP4SetMetadataAlbum'
mp4_tag.c:(.text+0x703): undefined reference to `MP4SetMetadataArtist'
mp4_tag.c:(.text+0x74a): undefined reference to `MP4SetMetadataTrack'
mp4_tag.c:(.text+0x762): undefined reference to `MP4SetMetadataDisk'
Still using too old API... giving up with this for now. One thing is for sure, if this isn't going to get fixed, libmp4v2-1.9.1_p479 will be kept and USE=mp4 removed from easytag.
Created attachment 306917 [details, diff]
Not backwards compatible libmp4v2_r479 patch
This patch appears to function with the tagging tests I've tried so far. It could still use more work and clean up though.
Has anyone bothered to report this upstream? (In reply to comment #4) > Has anyone bothered to report this upstream? I don't think so. Everyone just keeps adding themself to the CC list. The task is all yours if you want it :-) (In reply to comment #4) > Has anyone bothered to report this upstream? I sent a mail to their mailing list on Tuesday. Though I am not subscribed to the list and my message is still waiting for approval... I think I will just subscribe and resend next week if nothing will change. (In reply to comment #3) > Created attachment 306917 [details, diff] [details, diff] > Not backwards compatible libmp4v2_r479 patch > > This patch appears to function with the tagging tests I've tried so far. It > could still use more work and clean up though. Has anyone else tested this patch out? I'll probably push it upstream for feedback soon. (In reply to comment #7) > Has anyone else tested this patch out? I'll probably push it upstream for > feedback soon. This seems to work for me, but I have not a lot m4a files to test Thanks ! (In reply to comment #7) > (In reply to comment #3) > > Created attachment 306917 [details, diff] [details, diff] [details, diff] > > Not backwards compatible libmp4v2_r479 patch > > > > This patch appears to function with the tagging tests I've tried so far. It > > could still use more work and clean up though. > > Has anyone else tested this patch out? I'll probably push it upstream for > feedback soon. Works for me :) Thanks! Can we get a "Yes, I've tested this patch and changed tags in my .mp4 files succesfully." -type of confirmation? "It works for me." doesn't really cut it. (In reply to comment #10) > Can we get a "Yes, I've tested this patch and changed tags in my .mp4 files > succesfully." -type of confirmation? > "It works for me." doesn't really cut it. Yes, I've tested this patch and changed tags in my .m4a files. Also verified that I can't change tags in the very same files if easytag is compiled with "-mp4". committed the patch in as easytag-2.1.7-r2 *** Bug 416755 has been marked as a duplicate of this bug. *** |