Created attachment 306269 [details] build.log x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I.. -DLOCALEDIR=\"/usr/share/locale\" -DPACKAGE_DATA_DIR=\"/usr/share/easytag\" -march=barcelona -mtune=barcelona -O2 -pipe -Wall -pthread -I/usr/include/gtk-2.0 -I/usr/lib64/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng15 -I/usr/include/libdrm -c mp4_header.c mp4_header.c: In function ‘Mp4_Header_Read_File_Info’: mp4_header.c:207:5: error: too many arguments to function ‘MP4Read’ /usr/include/mp4v2/file.h:331:15: note: declared here mp4_header.c:221:9: error: too few arguments to function ‘MP4Close’ /usr/include/mp4v2/file.h:56:6: note: declared here mp4_header.c:246:5: error: too few arguments to function ‘MP4Close’ /usr/include/mp4v2/file.h:56:6: note: declared here make[3]: *** [mp4_header.o] Error 1 make[3]: Leaving directory `/var/tmp/portage/media-sound/easytag-2.1.7-r1/work/easytag-2.1.7/src' make[2]: *** [all-recursive] Error 1 make[2]: Leaving directory `/var/tmp/portage/media-sound/easytag-2.1.7-r1/work/easytag-2.1.7/src' make[1]: *** [all-recursive] Error 1 make[1]: Leaving directory `/var/tmp/portage/media-sound/easytag-2.1.7-r1/work/easytag-2.1.7' make: *** [all] Error 2 * ERROR: media-sound/easytag-2.1.7-r1 failed (compile phase): # emerge --info easytag Portage 2.2.0_alpha93 (default/linux/amd64/10.0/desktop/kde, gcc-4.6.3-asneeded, glibc-2.13-r4, 3.0.25 x86_64) ================================================================= System Settings ================================================================= System uname: Linux-3.0.25-x86_64-Quad-Core_AMD_Opteron-tm-_Processor_2389-with-gentoo-2.1 Timestamp of tree: Thu, 22 Mar 2012 06:45:02 +0000 app-shells/bash: 4.2_p24 dev-java/java-config: 2.1.11-r3 dev-lang/python: 2.7.2-r3, 3.2.2-r1 dev-util/cmake: 2.8.7-r5 dev-util/pkgconfig: 0.26 sys-apps/baselayout: 2.1 sys-apps/openrc: 0.9.9.3 sys-apps/sandbox: 2.5 sys-devel/autoconf: 2.13, 2.68 sys-devel/automake: 1.9.6-r3, 1.10.3, 1.11.3 sys-devel/binutils: 2.22-r1 sys-devel/gcc: 4.5.3-r2, 4.6.3_pre::poly-c sys-devel/gcc-config: 1.5.1-r1 sys-devel/libtool: 2.4.2 sys-devel/make: 3.82-r3 sys-kernel/linux-headers: 3.1 (virtual/os-headers) sys-libs/glibc: 2.13-r4 Repositories: gentoo kde-sunset poly-c Installed sets: @system ACCEPT_KEYWORDS="amd64 ~amd64" ACCEPT_LICENSE="*" CBUILD="x86_64-pc-linux-gnu" CFLAGS="-march=barcelona -mtune=barcelona -O2 -pipe" CHOST="x86_64-pc-linux-gnu" CONFIG_PROTECT="/etc /usr/kde/3.5/env /usr/kde/3.5/share/config /usr/kde/3.5/shutdown /usr/share/config /usr/share/gnupg/qualified.txt /var/lib/hsqldb" CONFIG_PROTECT_MASK="/etc/X11/Sessions /etc/X11/app-defaults /etc/X11/xinit /etc/adobe /etc/bonobo-activation /etc/ca-certificates /etc/ca-certificates.conf /etc/dbus-1 /etc/env.d /etc/env.d/java/ /etc/fonts /etc/fonts/fonts.conf /etc/foomatic /etc/games /etc/gconf /etc/gentoo-release /etc/gimp /etc/gnome-vfs-2.0 /etc/gre.d /etc/gtk-2.0 /etc/hp /etc/hsqldb /etc/htdig /etc/init.d /etc/iproute2 /etc/java-config-2 /etc/lftp /etc/logrotate.d /etc/ntop /etc/opt /etc/pango /etc/profile.d /etc/qt4 /etc/revdep-rebuild /etc/sandbox.d /etc/sasl2 /etc/sensors.d /etc/sgml /etc/sound /etc/ssl /etc/ssmtp /etc/t1lib /etc/terminfo /etc/vbox /etc/xdg /etc/xinetd.d /etc/xml" CXXFLAGS="-march=barcelona -mtune=barcelona -O2 -pipe" DISTDIR="/var/tmp/distfiles" EMERGE_DEFAULT_OPTS="--alphabetical --with-bdeps=y --misspell-suggestions=n --autounmask=n --quiet-build=n" FEATURES="assume-digests binpkg-logs collision-protect distlocks ebuild-locks fixlafiles news parallel-fetch protect-owned sandbox sfperms sign strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox" FFLAGS="" GENTOO_MIRRORS="ftp://sunsite.informatik.rwth-aachen.de/pub/Linux/gentoo ftp://linux.rz.ruhr-uni-bochum.de/gentoo-mirror/ ftp://ftp.tu-clausthal.de/pub/linux/gentoo/ http://gentoo.oregonstate.edu http://www.ibiblio.org/pub/Linux/distributions/gentoo" INSTALL_MASK="/lib/systemd /lib32/systemd /lib64/systemd /usr/lib/systemd /usr/lib32/systemd /usr/lib64/systemd" LDFLAGS="-Wl,-O1 -Wl,--hash-style=gnu -Wl,--sort-common -Wl,--as-needed" LINGUAS="de en" MAKEOPTS="-j8" PKGDIR="/opt/portage/packages" PORTAGE_CONFIGROOT="/" PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages" PORTAGE_TMPDIR="/var/tmp" PORTDIR="/var/portage" PORTDIR_OVERLAY="/var/lib/layman/kde-sunset /usr/local/portage" SYNC="rsync://192.168.0.254/gentoo-portage" USE="3dnow 3dnowext X a52 aac acpi alsa amd64 berkdb branding bzip2 cairo caps cdda cdr cli cracklib crypt css cups cxx dbus declarative dri dts dvd dvdr emboss encode exif fam ffmpeg firefox flac gdbm gdu gif gmp gnutls gtk iconv idn inotify jpeg jpeg2k kde kipi lame lcms libnotify lzma mad matroska midi mmap mmx mmxext mng modules mp3 mp4 mpeg mudflap multilib ncurses nls nptl nptlonly nsplugin ogg opengl openmp pam pango pcre pdf phonon plasma png ppds pppd qt3support qt4 quicktime readline rtmp schroedinger sdl semantic-desktop session slang spell sse sse2 ssl startup-notification svg sysfs theora threads tiff truetype twolame udev unicode usb vaapi vcd vorbis vpx x264 xcb xcomposite xinerama xml xorg xscreensaver xulrunner xv xvid zlib zsh-completion" ALSA_CARDS="emu10k1 hda-intel usb-audio" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file hooks iec958 ioplug ladspa lfloat linear meter mmap_emul mulaw multi null plug rate route share shm softvol" CALLIGRA_FEATURES="kexi words flow plan stage tables krita karbon braindump" CAMERAS="ptp2" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf superstar2 timing tsip tripmate tnt ubx" GRUB_PLATFORMS="pc" INPUT_DEVICES="evdev joystick" KERNEL="linux" LINGUAS="de en" PHP_TARGETS="php5-3" RUBY_TARGETS="ruby19" USERLAND="GNU" VIDEO_CARDS="radeon" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account" Unset: CPPFLAGS, CTARGET, LANG, LC_ALL, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS ================================================================= Package Settings ================================================================= media-sound/easytag-2.1.7-r1 was built with the following: USE="flac mp3 mp4 (multilib) -speex vorbis -wavpack"
Same issue here.
Created attachment 306307 [details, diff] Not backwards compatible and unfinished patch This solves the errors in the build.log attached but it still later fails: mp4_tag.o: In function `Mp4tag_Read_File_Tag': mp4_tag.c:(.text+0x66): undefined reference to `MP4GetMetadataName' mp4_tag.c:(.text+0x74): undefined reference to `MP4GetMetadataArtist' mp4_tag.c:(.text+0x82): undefined reference to `MP4GetMetadataAlbum' mp4_tag.c:(.text+0x96): undefined reference to `MP4GetMetadataDisk' mp4_tag.c:(.text+0xda): undefined reference to `MP4GetMetadataYear' mp4_tag.c:(.text+0xee): undefined reference to `MP4GetMetadataTrack' mp4_tag.c:(.text+0x104): undefined reference to `MP4GetMetadataGenre' mp4_tag.c:(.text+0x112): undefined reference to `MP4GetMetadataComment' mp4_tag.c:(.text+0x120): undefined reference to `MP4GetMetadataWriter' mp4_tag.c:(.text+0x12e): undefined reference to `MP4GetMetadataTool' mp4_tag.c:(.text+0x17b): undefined reference to `MP4GetMetadataCoverArt' mp4_tag.o: In function `Mp4tag_Write_File_Tag': mp4_tag.c:(.text+0x36b): undefined reference to `MP4SetMetadataName' mp4_tag.c:(.text+0x39e): undefined reference to `MP4SetMetadataArtist' mp4_tag.c:(.text+0x3d1): undefined reference to `MP4SetMetadataAlbum' mp4_tag.c:(.text+0x479): undefined reference to `MP4SetMetadataDisk' mp4_tag.c:(.text+0x4ac): undefined reference to `MP4SetMetadataYear' mp4_tag.c:(.text+0x50e): undefined reference to `MP4SetMetadataTrack' mp4_tag.c:(.text+0x541): undefined reference to `MP4SetMetadataGenre' mp4_tag.c:(.text+0x574): undefined reference to `MP4SetMetadataComment' mp4_tag.c:(.text+0x5a7): undefined reference to `MP4SetMetadataWriter' mp4_tag.c:(.text+0x5da): undefined reference to `MP4SetMetadataTool' mp4_tag.c:(.text+0x5e8): undefined reference to `MP4SetMetadataCoverArt' mp4_tag.c:(.text+0x61c): undefined reference to `MP4SetMetadataCoverArt' mp4_tag.c:(.text+0x65b): undefined reference to `MP4SetMetadataName' mp4_tag.c:(.text+0x673): undefined reference to `MP4SetMetadataTool' mp4_tag.c:(.text+0x68b): undefined reference to `MP4SetMetadataWriter' mp4_tag.c:(.text+0x6a3): undefined reference to `MP4SetMetadataComment' mp4_tag.c:(.text+0x6bb): undefined reference to `MP4SetMetadataGenre' mp4_tag.c:(.text+0x6d3): undefined reference to `MP4SetMetadataYear' mp4_tag.c:(.text+0x6eb): undefined reference to `MP4SetMetadataAlbum' mp4_tag.c:(.text+0x703): undefined reference to `MP4SetMetadataArtist' mp4_tag.c:(.text+0x74a): undefined reference to `MP4SetMetadataTrack' mp4_tag.c:(.text+0x762): undefined reference to `MP4SetMetadataDisk' Still using too old API... giving up with this for now. One thing is for sure, if this isn't going to get fixed, libmp4v2-1.9.1_p479 will be kept and USE=mp4 removed from easytag.
Created attachment 306917 [details, diff] Not backwards compatible libmp4v2_r479 patch This patch appears to function with the tagging tests I've tried so far. It could still use more work and clean up though.
Has anyone bothered to report this upstream?
(In reply to comment #4) > Has anyone bothered to report this upstream? I don't think so. Everyone just keeps adding themself to the CC list. The task is all yours if you want it :-)
(In reply to comment #4) > Has anyone bothered to report this upstream? I sent a mail to their mailing list on Tuesday. Though I am not subscribed to the list and my message is still waiting for approval... I think I will just subscribe and resend next week if nothing will change.
(In reply to comment #3) > Created attachment 306917 [details, diff] [details, diff] > Not backwards compatible libmp4v2_r479 patch > > This patch appears to function with the tagging tests I've tried so far. It > could still use more work and clean up though. Has anyone else tested this patch out? I'll probably push it upstream for feedback soon.
(In reply to comment #7) > Has anyone else tested this patch out? I'll probably push it upstream for > feedback soon. This seems to work for me, but I have not a lot m4a files to test Thanks !
(In reply to comment #7) > (In reply to comment #3) > > Created attachment 306917 [details, diff] [details, diff] [details, diff] > > Not backwards compatible libmp4v2_r479 patch > > > > This patch appears to function with the tagging tests I've tried so far. It > > could still use more work and clean up though. > > Has anyone else tested this patch out? I'll probably push it upstream for > feedback soon. Works for me :) Thanks!
Can we get a "Yes, I've tested this patch and changed tags in my .mp4 files succesfully." -type of confirmation? "It works for me." doesn't really cut it.
(In reply to comment #10) > Can we get a "Yes, I've tested this patch and changed tags in my .mp4 files > succesfully." -type of confirmation? > "It works for me." doesn't really cut it. Yes, I've tested this patch and changed tags in my .m4a files. Also verified that I can't change tags in the very same files if easytag is compiled with "-mp4".
committed the patch in as easytag-2.1.7-r2
*** Bug 416755 has been marked as a duplicate of this bug. ***