| Summary: | sys-apps/kexec-tools-2.0.2-r1 prints unnecessary message on stderr when loaded in VESA framebuffer | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Maxim Kammerer <mk> |
| Component: | [OLD] Core system | Assignee: | Justin Lecher (RETIRED) <jlec> |
| Status: | RESOLVED FIXED | ||
| Severity: | minor | ||
| Priority: | Normal | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | http://lists.infradead.org/pipermail/kexec/2012-March/006148.html | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
Could you please report this to upstream and leave to reference here? Thanks for that. This will be fixed in the next release (i would link to the mailing list message, but the archive server has been down all day): ====================================================== Agreed, I have pushed the following patch into the kexec-tools git tree and it should be included in the next release. From f1facd4b11aa141ffd9bbacb2631ad18dc33669c Mon Sep 17 00:00:00 2001 From: Simon Horman <horms@verge.net.au> Date: Mon, 12 Mar 2012 15:01:35 +0900 Subject: [PATCH] i386: Don't print debug message when VESA framebuffer is loaded This messages seems unnecessarily verbose. Reported-by: Maxim Kammerer <mk@dee.su> Signed-off-by: Simon Horman <horms@verge.net.au> --- kexec/arch/i386/x86-linux-setup.c | 3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/kexec/arch/i386/x86-linux-setup.c b/kexec/arch/i386/x86-linux-setup.c index 0528cea..08d64ca 100644 --- a/kexec/arch/i386/x86-linux-setup.c +++ b/kexec/arch/i386/x86-linux-setup.c @@ -151,9 +151,6 @@ int setup_linux_vesafb(struct x86_linux_param_header *real_mode) real_mode->rsvd_pos = var.transp.offset; real_mode->rsvd_size = var.transp.length; } - fprintf(stderr, "%s: %dx%dx%d @ %lx +%x\n", __FUNCTION__, - var.xres, var.yres, var.bits_per_pixel, - fix.smem_start, fix.smem_len); return 0; out: ====================================================== Cool, thans for your efforts. I will keep my eyes open and bump ASAP. |
In kexec/arch/i386/x86-linux-setup.c:setup_linux_vesafb(): fprintf(stderr, "%s: %dx%dx%d @ %lx +%x\n", __FUNCTION__, var.xres, var.yres, var.bits_per_pixel, fix.smem_start, fix.smem_len); This message is pretty annoying (especially if kexec is loaded several times with different parameters during startup/shutdown). Looking in that source file, that's the only fprintf which is not an error.