Summary: | kde-base/systemsettings-4.7.3 fails tests | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Paweł Hajdan, Jr. (RETIRED) <phajdan.jr> |
Component: | [OLD] KDE | Assignee: | Gentoo KDE team <kde> |
Status: | RESOLVED FIXED | ||
Severity: | normal | ||
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 241922 | ||
Attachments: |
build.log.gz
Test log, 1 fail out of 4 ebuild patch |
Description
Paweł Hajdan, Jr. (RETIRED)
2011-12-04 14:35:04 UTC
Created attachment 294771 [details]
Test log, 1 fail out of 4
FAIL! : FlagsTest::testRules() Compared values are not the same
Actual (flags->getLongText(layoutUnit, rules)): English (US)
Expected (QString("USA")): USA
Loc: [/var/tmp/portage/kde-base/systemsettings-4.7.3/work/systemsettings-4.7.3/kcontrol/keyboard/tests/flags_test.cpp(81)]
Final confirmation that whatever is spoken in the US is not really English... :)
Restricted tests for now, but this one looks like it can be fixed. gentoo64 systemsettings # ebuild systemsettings-4.7.3.ebuild test
>>> Working in BUILD_DIR: "/mnt/gen2/tmpdir/portage/kde-base/systemsettings-4.7.3/work/systemsettings-4.7.3_build"
Test project /mnt/gen2/tmpdir/portage/kde-base/systemsettings-4.7.3/work/systemsettings-4.7.3_build
Start 1: xkb_rules_test
1/4 Test #1: xkb_rules_test ...................***Failed 0.02 sec
Start 2: iso_codes_test
2/4 Test #2: iso_codes_test ................... Passed 0.41 sec
Start 3: flags_test
3/4 Test #3: flags_test .......................***Failed 0.04 sec
Start 4: layout_memory_persister_test
4/4 Test #4: layout_memory_persister_test .....***Failed 0.02 sec
gentoo64 kcontrol # pwd
/mnt/gen2/tmpdir/portage/kde-base/systemsettings-4.7.3/work/systemsettings-4.7.3_build/kcontrol
gentoo64 kcontrol # make test
Test project /mnt/gen2/tmpdir/portage/kde-base/systemsettings-4.7.3/work/systemsettings-4.7.3_build/kcontrol
Start 1: xkb_rules_test
1/4 Test #1: xkb_rules_test ................... Passed 0.39 sec
Start 2: iso_codes_test
2/4 Test #2: iso_codes_test ................... Passed 0.40 sec
Start 3: flags_test
3/4 Test #3: flags_test .......................***Failed 0.19 sec
Start 4: layout_memory_persister_test
4/4 Test #4: layout_memory_persister_test ..... Passed 0.05 sec
Some bugs are like pulling teeth.
The setting of the "(US" appears to be in a file base2.xml. This file is generated, but not until the onset of the test phase itself. I'm damned if I can find the file that contains the text at unpack.
See you in irc!!
VIRTUALX_REQUIRED="test" secures the single failure of FlagsTest::testRules(). Comparing English (US) to USA; appears to come down to this line QCOMPARE( flags->getLongText(layoutUnit, rules), QString("USA") ); would think it routine but could not figure how to get the strings to match. Created attachment 299693 [details, diff]
ebuild patch
for ebuild 4.7.4
This still needs a fix to the previously stated line in the data .cpp file.
Someone will hopefully know what change to make. The parameter 'rules' could hold the key. This time running 4.7.4 yielded the 1st. reported result of 3 out of 4 passes.
This one does NOT include the dbus reference.
Fixed in 4.8.2 at least. (In reply to comment #6) > Fixed in 4.8.2 at least. Not really, they now hang. :( In the overlay, all tests now pass with the addition of virtual dbus. The eclass modifications are now in the main tree, and tests are now passing. |