| Summary: | net-im/psi-0.14-r4 fails to build with sys-libs/zlib-1.2.5.1 | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Nikolaj Šujskij <skrattaren> |
| Component: | Current packages | Assignee: | Peter Volkov (RETIRED) <pva> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | Martin.vGagern, nikoli, s9gf4ult |
| Priority: | Normal | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: |
net-im/psi-0.14-r4 full build log
patch for compile psi with new zlib patch to fix compilation with zlib-1.2.5.1-r1 |
||
|
Description
Nikolaj Šujskij
2011-10-21 08:51:17 UTC
Created attachment 290447 [details]
patch for compile psi with new zlib
Created attachment 290489 [details] patch to fix compilation with zlib-1.2.5.1-r1 I was told in bug #383431 that using the macro _Z_OF is a bad idea. Attached is a patch that works too and does not use this macro. Both patches apply cleanly and fix compilation issue (thanks to both authors), and Michael's one looks more pretty. Guys, could you try different solution:
Index: psi-0.14-r4.ebuild
===================================================================
RCS file: /var/cvsroot/gentoo-x86/net-im/psi/psi-0.14-r4.ebuild,v
retrieving revision 1.5
diff -u -B -r1.5 psi-0.14-r4.ebuild
--- psi-0.14-r4.ebuild 23 Oct 2011 11:33:51 -0000 1.5
+++ psi-0.14-r4.ebuild 24 Oct 2011 08:54:39 -0000
@@ -36,7 +36,8 @@
spell? ( >=app-text/enchant-1.3.0 )
xscreensaver? ( x11-libs/libXScrnSaver )
extras? ( webkit? ( x11-libs/qt-webkit ) )
- app-arch/unzip"
+ app-arch/unzip
+ || ( >=sys-libs/zlib-1.2.5.1-r2[minizip] <sys-libs/zlib-1.2.5.1-r1 )"
DEPEND="${RDEPEND}
extras? ( sys-devel/qconf )
(In reply to comment #4) > Guys, could you try different solution: > + || ( >=sys-libs/zlib-1.2.5.1-r2[minizip] <sys-libs/zlib-1.2.5.1-r1 )" No solution, I believe: I had sys-libs/zlib-1.2.5.1-r2[minizip] installed when I encountered this issue, so that alone isn't enough to fix this use of the OF macro. Thank you for report/tests, guys. Fixed in tree. *** Bug 388429 has been marked as a duplicate of this bug. *** > Guys, could you try different solution:
> + || ( >=sys-libs/zlib-1.2.5.1-r2[minizip] <sys-libs/zlib-1.2.5.1-r1 )"
Er... Why has it made into ebuild? Both suggested patches don't need zlib to be built with +minizip, Psi could be built and run with sys-libs/zlib-1.2.5.1-r2[-minizip]. I wanted to check current ebuild with `--nodeps` but it failed ultimately with `qconf: command not found`.
P.S. Contrary to last entry in net-im/psi ChangeLog, I haven't contributed fix _at all_ :)
(In reply to comment #8) > > Guys, could you try different solution: > > + || ( >=sys-libs/zlib-1.2.5.1-r2[minizip] <sys-libs/zlib-1.2.5.1-r1 )" > > Er... Why has it made into ebuild? Both suggested patches don't need zlib to > be built with +minizip, Psi could be built and run with > sys-libs/zlib-1.2.5.1-r2[-minizip]. I wanted to check current ebuild with > `--nodeps` but it failed ultimately with `qconf: command not found`. ...which is reported as #388727. And if I move qconf back under `if use extras` section, then Psi is built all right with sys-libs/zlib-1.2.5.1-r2[-minizip], so I reopen this bug. P.S. Could you please add calling `epatch_user` function to ebuild to let people drop custom patches to /etc/portage/patches//net-im/psi? (In reply to comment #8) > > Guys, could you try different solution: > > + || ( >=sys-libs/zlib-1.2.5.1-r2[minizip] <sys-libs/zlib-1.2.5.1-r1 )" > > Er... Why has it made into ebuild? Every distribution has policy to avoid bundled libraries. Psi uses zlib with minizip and thus we should depend on zlib[minizip]. > I wanted to check current ebuild with > `--nodeps` but it failed ultimately with `qconf: command not found`. Fixed in tree. Thanks. (In reply to comment #9) > P.S. Could you please add calling `epatch_user` function to ebuild to let > people drop custom patches to /etc/portage/patches//net-im/psi? No. This makes patches invisible for me. |
