Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 377757

Summary: sys-fs/iprutils should respect CFLAGS, LDFLAGS, CC, ChangeLog does not exist
Product: Gentoo Linux Reporter: Jeroen Roovers (RETIRED) <jer>
Component: Current packagesAssignee: ppc64 architecture team <ppc64>
Severity: QA CC: c1pher, esigra, pinkbyte
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 243502, 331933    
Attachments: build.log
Patch to iprutils-2.3.9.ebuild
Patch for Makefile

Description Jeroen Roovers (RETIRED) gentoo-dev 2011-08-04 15:41:05 UTC
Created attachment 282069 [details]

gcc -g -Wall -DIPR_MAJOR_RELEASE=2 -DIPR_MINOR_RELEASE=3 -DIPR_FIX_LEVEL=0 -DIPR_FIX_DATE='"(Aug 13, 2010)"' -DIPR_VERSION_STR='"2.3.0 (Aug 13, 2010)"' -DIPR_RELEASE=1 -I. -I/usr/include/ncurses -o iprconfig iprconfig.c iprlib.o -lform -lpanel -lncurses -lmenu -lsysfs
gcc -g -Wall -DIPR_MAJOR_RELEASE=2 -DIPR_MINOR_RELEASE=3 -DIPR_FIX_LEVEL=0 -DIPR_FIX_DATE='"(Aug 13, 2010)"' -DIPR_VERSION_STR='"2.3.0 (Aug 13, 2010)"' -DIPR_RELEASE=1 -I. -I/usr/include/ncurses -o iprupdate iprlib.o iprupdate.c -lsysfs

and so on. Disrespects CC, injects -g, ignores CFLAGS.

 * QA Notice: file does not exist:
 *      dodoc: ChangeLog does not exist

 * QA Notice: Files built without respecting LDFLAGS have been detected
 *  Please include the following list of files in your report:
 * /sbin/iprconfig
 * /sbin/iprdump
 * /sbin/iprinit
 * /sbin/iprupdate
 * /sbin/iprdbg
Comment 1 Dane Smith (RETIRED) gentoo-dev 2012-11-12 20:28:11 UTC
Created attachment 329376 [details]
Patch to iprutils-2.3.9.ebuild

Patch. Bump to EAPI 4. Drop useless ebeep. Make use of patch to Makefile to deal with lack of toolchain respect.
Comment 2 Dane Smith (RETIRED) gentoo-dev 2012-11-12 20:29:42 UTC
Created attachment 329378 [details]
Patch for Makefile

Fixes CFLAGS, LDFLAGS, and Compiler respect.
Comment 3 Dane Smith (RETIRED) gentoo-dev 2012-11-12 20:31:20 UTC
Brent - Let me know if you have any objections to any of these changes. If I don't hear anything in a week or so I'm going to go ahead and commit them.
Comment 4 Jeroen Roovers (RETIRED) gentoo-dev 2012-11-13 01:20:24 UTC
Comment on attachment 329376 [details]
Patch to iprutils-2.3.9.ebuild

I say get rid of the einfos. :)
Comment 5 Sergey Popov gentoo-dev 2014-12-23 14:41:58 UTC
Created attachment 392276 [details]

Ebuild for version 2.3.18 with changes, based on previously suggested patches by Dane Smith
Comment 6 Sergey Popov gentoo-dev 2014-12-25 13:02:43 UTC
+*iprutils-2.3.18 (25 Dec 2014)
+  25 Dec 2014; Sergey Popov <> -iprutils-2.3.0.ebuild,
+  +iprutils-2.3.18.ebuild:
+  Version bump, respect compiler, CFLAGS and LDFLAGS, wrt bug #377757. Drop old
+  version