Bug 371635 – app-portage/getdelta picks bad source file names

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Xake 2011-06-14 16:39:06 UTC]

So...
I have app-portage/getdelta-0.7.8 installed with the patch applied to make it work with EAPI=2 and higher.

But...

Somehow getdelta thinks it is fun to download a file bigger then what is manifested...

>>> Fetching (69 of 1230) sys-devel/bin86-0.16.18
>>> Downloading 'http://distfiles.gentoo.org/distfiles/bin86-0.16.18.tar.gz'
Searching for a previously downloaded file in /var/portage/distfiles

We have the following candidates to choose from 
bind-9.7.3.tar.gz 

The best of all is ... bind-9.7.3.tar.gz

Checking if this file is OK.

Trying to download bind-9.7.3.tar.gz-bin86-0.16.18.tar.gz.dtu

--2011-06-14 17:58:46--  http://linux01.gwdg.de/~nlissne/deltup.php?have=bind-9.7.3.tar.gz&want=bin86-0.16.18.tar.gz&url=http://www.debath.co.uk/dev86/bin86-0.16.18.tar.gz&version=0.7&time=1308067126
Resolving linux01.gwdg.de (linux01.gwdg.de)... 134.76.13.21
Connecting to linux01.gwdg.de (linux01.gwdg.de)|134.76.13.21|:80... connected.
HTTP request sent, awaiting response... 302 Moved Temporarily
Location: http://91.191.147.227:81/bind-9.7.3.tar.gz-bin86-0.16.18.tar.gz.dtu [following]
--2011-06-14 17:58:47--  http://91.191.147.227:81/bind-9.7.3.tar.gz-bin86-0.16.18.tar.gz.dtu
Connecting to 91.191.147.227:81... connected.
HTTP request sent, awaiting response... 200 OK
Length: 276024 (270K) [application/octet-stream]
Saving to: `bind-9.7.3.tar.gz-bin86-0.16.18.tar.gz.dtu'

68% [======================================================================================================================================================================================================>                                                                                           ] 189,889     5.89K/s  eta 17s     ^

However:
 emerge -pv bin86

These are the packages that would be merged, in order:

Calculating dependencies... done!
[ebuild   R    ] sys-devel/bin86-0.16.18  143 kB

Total: 1 package (1 reinstall), Size of downloads: 143 kB



So I guess this is really two bugs:
first is that getdelta.sh should be better att figuring out what a good candidate for a bin-delta may be.
second is that getdelta should query the server to see if the delta is acctually smaller then the original download.

I think first could be easily implemented fetching ${P} (and maybe check for ${MY_P}) from the environment and compare it to ${FILE}, and if it is a match, us it to figure out what is a comparable match found in ${DISTDIR}.
Second one coulöd be harder as you may not be able to trust the info from the server, and you must have one way to look up the metadata for the ebuild in question to make sure that the dtu acctually is smaller.

[Comment 1 Pavel Kozlov 2018-07-02 19:36:05 UTC]

Hello! Is getdelta still supported by gentoo? When I try to use it, I see response from linux01.dwdg.de "Your request has been queued (Pos. 21154)", and that's it, no delta, next thing wget just downloads the full size file.

[Comment 2 Larry the Git Cow 2021-08-24 12:39:10 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b965153d7733fe0a58bdd54a378cd337e76a420c

commit b965153d7733fe0a58bdd54a378cd337e76a420c
Author:     Jakov Smolic <[e-mail]>
AuthorDate: 2021-08-24 12:38:35 +0000
Commit:     David Seifert <[e-mail]>
CommitDate: 2021-08-24 12:38:35 +0000

    app-portage/getdelta: Remove last-rited package
    
    Closes: https://bugs.gentoo.org/371635
    Bug: https://bugs.gentoo.org/630814
    Signed-off-by: Jakov Smolic <[e-mail]>
    Signed-off-by: David Seifert <[e-mail]>

 app-portage/getdelta/Manifest                   |   1 -
 app-portage/getdelta/files/getdelta-0.7.9.patch | 252 ------------------------
 app-portage/getdelta/getdelta-0.7.9-r2.ebuild   |  46 -----
 app-portage/getdelta/metadata.xml               |   8 -
 profiles/package.mask                           |   5 -
 5 files changed, 312 deletions(-)