| Summary: | x11-libs/qt-gui should not remove QMacStyle from the installed headers | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Enrico Ros <koral> |
| Component: | New packages | Assignee: | Qt Bug Alias <qt> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | ||
| Priority: | High | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/x11-libs/qt-gui/qt-gui-4.7.3.ebuild?view=markup | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Bug Depends on: | |||
| Bug Blocks: | 390963 | ||
Yes, I agree with the reporter. I always wondered why we remove those headers. Are there any good reasons to do so? Other linux distros don't seem to be doing that. Fixed in qting-edge for now. Fixed in qt-gui-4.7.4 and 4.7.4-r1. Thanks for reporting! |
The QMacStyle header file is removed from the headers to be installed on disk. However, the file already contains the guard that checks if the feature is enabled so including is cheap. On the other hand, removing the file from disk may cause some projects to fail. Suggested fix: patch the ebuild to remove the following lines: 145 # remove Mac OS X headers 146 use aqua || rm -f \ 147 "${D}${QTHEADERDIR}"/{Qt,QtGui}/qmacstyle_mac.h \ 148 "${D}${QTHEADERDIR}"/QtGui/QMacStyle The bug has been originally reported on the WebKit project at this URL: https://bugs.webkit.org/show_bug.cgi?id=61092 Reproducible: Always Steps to Reproduce: 1. download WebKit from the official site, checkout version 79407 or later (87144 as of now) 2. start the build with Tools/Scripts/build-webkit --qt --debug 3. wait until it breaks for the missing header Actual Results: Build breaks. Expected Results: Build succeeds. We will fix the webkit inclusion, but the removal of that file may impact other projects as well.