Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 368515 - x11-libs/qt-gui should not remove QMacStyle from the installed headers
Summary: x11-libs/qt-gui should not remove QMacStyle from the installed headers
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Qt Bug Alias
URL: http://sources.gentoo.org/cgi-bin/vie...
Whiteboard:
Keywords:
Depends on:
Blocks: qt-4.7.4-stable
  Show dependency tree
 
Reported: 2011-05-24 01:48 UTC by Enrico Ros
Modified: 2011-11-28 22:54 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Enrico Ros 2011-05-24 01:48:17 UTC
The QMacStyle header file is removed from the headers to be installed on disk. However, the file already contains the guard that checks if the feature is enabled so including is cheap. On the other hand, removing the file from disk may cause some projects to fail.

Suggested fix: patch the ebuild to remove the following lines:
145	        # remove Mac OS X headers
146	        use aqua || rm -f \
147	                "${D}${QTHEADERDIR}"/{Qt,QtGui}/qmacstyle_mac.h \
148	                "${D}${QTHEADERDIR}"/QtGui/QMacStyle


The bug has been originally reported on the WebKit project at this URL:
https://bugs.webkit.org/show_bug.cgi?id=61092

Reproducible: Always

Steps to Reproduce:
1. download WebKit from the official site, checkout version 79407 or later (87144 as of now)
2. start the build with Tools/Scripts/build-webkit --qt --debug
3. wait until it breaks for the missing header
Actual Results:  
Build breaks.

Expected Results:  
Build succeeds.

We will fix the webkit inclusion, but the removal of that file may impact other projects as well.
Comment 1 Davide Pesavento gentoo-dev 2011-05-24 14:47:16 UTC
Yes, I agree with the reporter. I always wondered why we remove those headers. Are there any good reasons to do so? Other linux distros don't seem to be doing that.
Comment 2 Davide Pesavento gentoo-dev 2011-11-12 21:42:23 UTC
Fixed in qting-edge for now.
Comment 3 Davide Pesavento gentoo-dev 2011-11-28 22:54:32 UTC
Fixed in qt-gui-4.7.4 and 4.7.4-r1. Thanks for reporting!