| Summary: | xf86-input-mtrack-0.1.0.ebuild (New Package) | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Ryan Bourgeois <bluedragonx> |
| Component: | New packages | Assignee: | Default Assignee for New Packages <maintainer-wanted> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | barbieri, naota, x11 |
| Priority: | Normal | Keywords: | InVCS |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: |
xf86-input-mtrack-0.1.0.ebuild
mtdev-1.1.0.ebuild xf86-input-mtrack-0.1.1.ebuild my version of ebuild sys-libs/mtdev-1.1.0.ebuild revised mtdev-1.1.0.ebuild xf86-input-mtrack-0.1.1-autoconf.patch xf86-input-mtrack-0.1.1.ebuild using xorg-2 |
||
Created attachment 270387 [details]
mtdev-1.1.0.ebuild
The mtdev library is a dependency of xf86-input-mtrack. Also attached is mtdev-1.1.0.ebuild for that library.
Created attachment 271421 [details]
xf86-input-mtrack-0.1.1.ebuild
Attached is the new ebuild for v0.1.1 of the xf86-input-mtrack driver. The contents of the ebuild are identical to the old one, the version being bumped via the filename.
Created attachment 272365 [details]
my version of ebuild
This is my version of ebuild. Fixed some errors (gcc, CFLAGS, LDFLAGS, lib vs lib64) and use github auto-generated tarball.
x11 team,
how do you think about category of mtdev. I think it would be better to be x11-libs/ (original ebuild categorized it to sys-libs/)
X11 team ebuilds must always use latest availible eapi, in this case 4. Please update your ebuilds with them. For the driver just use xorg-2 eclass if possible. mtdev apparently uses no other parts of X (protos, headers, etc.) so it is not really related to other packages in x11-libs. (In reply to comment #4) > X11 team ebuilds must always use latest availible eapi, in this case 4. Please > update your ebuilds with them. My ebuild is using eapi4. Are there some error with it? (attachment "my version of ebuild") > For the driver just use xorg-2 eclass if possible. Since this is a third-party driver, I don't think using xorg-2 eclass is better. (In reply to comment #5) > mtdev apparently uses no other parts of X (protos, headers, etc.) so it is not > really related to other packages in x11-libs. OK, I'll put it in sys-libs You didn't attach mtdev ebuild i was complaining about :) Created attachment 272501 [details]
sys-libs/mtdev-1.1.0.ebuild
I see. Here is a EAPI=4 version of mtdev ebuild (almost the same)
(In reply to comment #8) > Created attachment 272501 [details] > sys-libs/mtdev-1.1.0.ebuild > > I see. Here is a EAPI=4 version of mtdev ebuild (almost the same) Use default src_install phase for eapi4... Make static library optional or do not install it at all... Drop the .la file completely. Created attachment 272701 [details]
revised mtdev-1.1.0.ebuild
sed -e 's:emake DESTDIR="${D}" install:default:'
Other than that feel free to commit mtdev to main tree with x11 as herd :)
FWIW on the xf86-input-mtrack really try to move it to xorg-2 eclass first
(also might be worth writting simple autoconf build (+-15 lines if you steal it from another xf86-input-something driver).
Created attachment 272911 [details, diff]
xf86-input-mtrack-0.1.1-autoconf.patch
Created attachment 272913 [details]
xf86-input-mtrack-0.1.1.ebuild using xorg-2
I've wrote an autoconf patch for mtrack package and xorg-2 using ebuild.
Please review them.
Drop the useless inherits xorg-2 is enough. move the patch to PATCHES=() array in global scope thus dropping the src_prepare Call the xorg-2_pkg_setup in pkg_setup phase. Drop dependency over xinputproto and that xorg-server, both handled by eclass itself. And feel free to commit that :) I've commit the ebuild. Thanks. |
Created attachment 270385 [details] xf86-input-mtrack-0.1.0.ebuild Attached is xf86-input-mtrack-0.1.0.ebuild, an ebuild for the first release of the xf86-input-mtrack driver. xf86-input-mtrack is a multitouch Xorg driver riginally intended to make functional the new Macbook trackpads with integrated button. It will also work on other trackpads supporting the multitouch protocol. The category should be x11-drivers.