Summary: | media-gfx/inkscape-0.48.1 fails to build with gcc-4.6 | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | emil karlson <jekarlson> |
Component: | [OLD] Unspecified | Assignee: | Gentoo Graphics Project <graphics+disabled> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | rhill, tdalman |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 346809 | ||
Attachments: |
patch for compilation with gcc-4.6 untested on older gcc
A new patch with no --export-dynamic |
Description
emil karlson
2011-04-08 17:12:02 UTC
Created attachment 269051 [details, diff]
patch for compilation with gcc-4.6 untested on older gcc
patch for compilation with gcc-4.6, untested on older gcc
upstreamed too: https://bugs.launchpad.net/inkscape/+bug/754870 Builds fine here with the patch. gcc-4.5.2. Also builds fine here. Same patch but created by myself. Why is this not in gcc-porting? (In reply to comment #4) > Also builds fine here. Same patch but created by myself. Why is this not in > gcc-porting? This may or may not fail compile on osX and freebsd linkers, upstream may or may not have relied on some funny case of compiler ignoring --export-dynamic on some operating systems and actually taking it into account on some operatin systems... Upstream is still discussing the issue and most people there don't seem to have a clue anymore than I have =o) Reviewing the other upstreamed patch, it's essentially the same as my patch but a bit more bulky, perhaps some other configuration options required more modifications. Created attachment 269549 [details]
A new patch with no --export-dynamic
For all I know this patch behaviour is equivalent to that of gcc-4.5 and makes a lot more sense.
No one in upstream could explain the relevance of --export-dynamic on any system.
Tested under gnu/linux with gcc-4.5 and gcc-4.6.
Should also work on osX and freebsd, unlike the previous patch.
Is this bug fixed then ? (In reply to comment #7) > Is this bug fixed then ? Nope, upstream still silent and no patch has been included in portage. (In reply to comment #8) > (In reply to comment #7) > > Is this bug fixed then ? > > Nope, upstream still silent and no patch has been included in portage. Since your patch apparently works on all current gcc versions, I would like to see a portage -r1 patch :-) Regarding your patch: it looks good to me, however I'm also unsure about --export-dynamic. Does -Wl,--export-dynamic work on gcc-4.6 ? If so, I would prefer this former variant to match the upstream's original intention with --export-dynamic (whatever that might have been). Thanks! -Wl,--export-dynamic doesn't work with non-gnu linkers. Just drop it, it's been ignored by the gcc driver for a long time now. Fixed in the latest revbump in CVS, thanks. |