Summary: | <media-video/gxine-0.5.906 fails to compile with >=dev-lang/spidermonkey-1.8.5 | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Sebastian Luther (few) <SebastianLuther> |
Component: | Current packages | Assignee: | Gentoo Media-video project <media-video> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | david.w.noon, galtgendo, help, mozilla |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
See Also: | https://bugs.xine-project.org/show_bug.cgi?id=419 | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 376987 | ||
Attachments: |
build.log
migration to spidermonkey-1.8.5 Patch to make ebuild support spidermonkey-1.8.5 |
Description
Sebastian Luther (few)
2011-03-28 17:49:52 UTC
*** This bug has been marked as a duplicate of bug 350134 *** Marked as duplicate because a) 0.5.905 is no longer in Portage b) -r1 has the fix and is stable I've got the same error with -r1 reopen. is this with xulrunner-2 installed or... ? No, I don't have xulrunner installed. It's ACCEPT_KEYWORDS="x86" system, gxine's use flags are USE="nls xcb -gnome -lirc -nsplugin -udev -xinerama", pratom.h and such exist in /usr/include/nspr/. Just tested building with nsplugin USE flag enabled - error is gone. Well, now that spidermonkey 1.8.5 went into the tree, it's time to revisit. There's a patch in upstream bugzilla - I briefly tested it and things seemed to work fine. However, it would be nice to know if something can be done about the flood of warnings from /usr/include/js/jsapi.h - mozilla herd, any ideas ? Seems whatever JS_ALWAYS_INLINE (js/jstypes.h) expands to doesn't agree with gcc. On unrelated note: I think passing '--disable-deprecated' to configure wouldn't hurt. Comment from bug 376863, the upstream patch to support spidermonkey-1.8.5 should probably be integrated ASAP...: If I unmask spidermonkey, than 'emerge gxine' installs spidermonkey-1.8.5 as dependency and than fails with: ... player.c:1259:7: warning: initialization from incompatible pointer type x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I../include -I../include -I../include -I/usr/include -I../pixmaps -std=gnu99 -pthread -DQT_SHARED -I/usr/include/gtk-2.0 -I/usr/lib64/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng14 -I/usr/include/qt4 -I/usr/include/qt4/QtGui -I/usr/include/libdrm -I/usr/include/qt4/QtCore -pthread -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/nspr -pthread -I/usr/include/gudev-1.0 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -pthread -I/usr/include/dbus-1.0 -I/usr/lib64/dbus-1.0/include -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/js -DLOCALEDIR=\"/usr/share/locale\" -march=native -O2 -pipe -c script_engine.c make[2]: *** [player.o] Error 1 ... make[2]: *** Waiting for unfinished jobs.... In file included from /usr/include/js/jspubtd.h:47:0, from /usr/include/js/jsapi.h:49, from script_engine.h:34, from globals.h:39, from playlist.c:24: /usr/include/js/jsval.h:565:1: warning: ‘inline’ attribute directive ignored ... /usr/include/js/jsapi.h:3800:1: warning: ‘inline’ attribute directive ignored playlist.c: In function ‘playlist_load’: playlist.c:435:3: warning: ‘xml_parser_init’ is deprecated (declared at /usr/include/xine/xmlparser.h:64) ... /usr/include/js/jsapi.h:3800:1: warning: ‘inline’ attribute directive ignored post.c: In function ‘post_init’: post.c:1109:5: warning: initialization from incompatible pointer type post.c:1111:5: warning: initialization from incompatible pointer type post.c:1113:5: warning: initialization from incompatible pointer type In file included from /usr/include/js/jstl.h:43:0, from /usr/include/js/jshashtable.h:46, from /usr/include/js/jsstr.h:54, from script_engine.c:37: /usr/include/js/jsbit.h:255:11: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘js’ In file included from /usr/include/js/jshashtable.h:46:0, from /usr/include/js/jsstr.h:54, from script_engine.c:37: /usr/include/js/jstl.h:46:15: fatal error: new: No such file or directory compilation terminated. make[2]: *** [script_engine.o] Error 1 Created attachment 282105 [details, diff] migration to spidermonkey-1.8.5 This patch was submitted upstream as part of https://bugs.xine-project.org/show_bug.cgi?id=419 I have modified it just slightly so that it can be cleanly applied just before the existing -spidermonkey-update.patch (which is still needed). Patch for ebuild to follow Created attachment 282107 [details]
Patch to make ebuild support spidermonkey-1.8.5
This patch shows what is needed to apply the previous attachment and also get gxine configured properly for spidermonkey-1.8.5.
Since pkg-config should now be used to detect the spidermonkey settings, specifying the spidermonkey include path directly is no longer valid for 1.8.5 and above.
This should be fixed in gxine-0.5.906 but I left it in tree with KEYWORDS="" because it's only crashing here (after initial startup) to some memory allocation problem (this could be a local problem on my machine, and I don't have time to debug it now) Feel free to take over and add the KEYWORDS if this works for you Well, gxine 0.9.906 works fine here with spidermonkey 1.8.5 (on x86)... but I'm using a bit different ebuild, as I forgot to file a version bump, once I've noticed that release. + 10 Oct 2011; Samuli Suominen <ssuominen@gentoo.org> gxine-0.5.906.ebuild: + Release to ~arch for testing. This one works with mozjs185 wrt #360971 by + Sebastian Luther and Ian Stakenvicius. |