Summary: | Eclass changes for Prefix to php-ext-source-r2.eclass | ||
---|---|---|---|
Product: | Gentoo/Alt | Reporter: | nietonfir |
Component: | Prefix Support | Assignee: | Gentoo Prefix <prefix> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | php-bugs |
Priority: | Normal | Keywords: | Inclusion, PATCH |
Version: | unspecified | ||
Hardware: | All | ||
OS: | OS X | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | 358985 | ||
Bug Blocks: | 315803 | ||
Attachments: |
prefixed pecl-imagick ebuild
prefixed php eclass for external libraries ebuild diff eclass diff eclass diff eprefixified php-ext-source-v2.eclass eclass diff eprefixified php-ext-source-v2.eclass eclass diff |
Description
nietonfir
2011-03-15 10:19:32 UTC
Created attachment 265919 [details]
prefixed php eclass for external libraries
Created attachment 265921 [details, diff]
ebuild diff
Created attachment 265923 [details, diff]
eclass diff
This way it should be easier to review the changes.
Created attachment 265925 [details, diff]
eclass diff
My wrong, picked the wrong diff, sry!
*** Bug 383161 has been marked as a duplicate of this bug. *** Created attachment 286791 [details]
eprefixified php-ext-source-v2.eclass
Created attachment 286793 [details, diff]
eclass diff
Updated diff of the new eclass
Created attachment 291287 [details]
eprefixified php-ext-source-v2.eclass
Created attachment 291289 [details, diff]
eclass diff
Is there anything wrong with the eprefixified eclass or this ebuild?
Looks ok to me, apart from that we have to define EPREFIX when we want to use it and the EAPI is not 3 (or higher). @php-bugs: how do you think about the patch, provided we add the definition for EPREFIX for older EAPIs? It looks good to me. @grobian: have you ever committed the patch? no, because we need the bit suggested in comment #10, and it awaits approval in comment #11 (In reply to comment #13) > no, because we need the bit suggested in comment #10, and it awaits approval > in comment #11 The eclass in the current version supports EAPI=2,3,4 so has "${EAPI}" 2 && ! use prefix && EPREFIX= should do the job, right? (In reply to comment #14) > (In reply to comment #13) > > no, because we need the bit suggested in comment #10, and it awaits approval > > in comment #11 > The eclass in the current version supports EAPI=2,3,4 so > > has "${EAPI}" 2 && ! use prefix && EPREFIX= > > should do the job, right? Yup. I'll add a twist though, if you look at which ebuilds are EAPI2 or lower and inherit this eclass, there are not many. ESPECIALLY after cleaning up old versions: http://qa-reports.gentoo.org/output/eapi-per-eclass/php-ext-source-r2.eclass/2.txt Maybe the php team wants to clean up the old ebuild, migrate the remaining couple packages to EAPI>=3 then make the eclass only support EAPI>=3 ?? Actually working on it right now :) (In reply to comment #16) > Actually working on it right now :) EAPI2 ebuilds have been gone from the tree for some time now. The eclass is EAPI=[45] now, so applying attachment 291289 [details, diff] should be the only thing missing.
Sorry, I didn't realize this was here and committed more or less the same thing over in bug #371985. |