Bug 356729

Summary:	[gnome-overlay] gnome-base/gnome-control-center-2.91.90 and -9999 fails to build due to new NetworkManager modem API
Product:	Gentoo Linux	Reporter:	Alexandre Rostovtsev (RETIRED) <tetromino>
Component:	[OLD] GNOME	Assignee:	Gentoo Linux Gnome Desktop Team <gnome>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	High
Version:	unspecified
Hardware:	All
OS:	Linux
URL:	https://bugzilla.gnome.org/show_bug.cgi?id=643390
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	353071
Attachments:	patch for new NetworkManager API

Description Alexandre Rostovtsev (RETIRED) gentoo-dev

2011-02-27 18:17:47 UTC

The gnome-base/gnome-control-center-2.91.90 and -9999 ebuilds from Gnome overlay currently require networkmanager-9999.

With commit 2140dad5e0de0033e5c9bb10bd77ecd80085e5a3 (see (http://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=2140dad5e0de0033e5c9bb10bd77ecd80085e5a3), networkmanager's API for broadband modems has changed, and gnome-control-center (both 2.91.90 and 9999) now fails to build:

cc-network-panel.c: In function 'panel_add_device':
cc-network-panel.c:379:21: error: 'NM_DEVICE_TYPE_GSM' undeclared (first use in this function)
cc-network-panel.c:379:21: note: each undeclared identifier is reported only once for each function it appears in
cc-network-panel.c:380:21: error: 'NM_DEVICE_TYPE_CDMA' undeclared (first use in this function)
cc-network-panel.c: In function 'nm_device_refresh_item_ui':
cc-network-panel.c:757:28: error: 'NM_DEVICE_TYPE_GSM' undeclared (first use in this function)
cc-network-panel.c:758:28: error: 'NM_DEVICE_TYPE_CDMA' undeclared (first use in this function)
panel-common.c: In function 'panel_device_type_to_icon_name':
panel-common.c:42:14: error: 'NM_DEVICE_TYPE_GSM' undeclared (first use in this function)
panel-common.c:42:14: note: each undeclared identifier is reported only once for each function it appears in
panel-common.c:43:14: error: 'NM_DEVICE_TYPE_CDMA' undeclared (first use in this function)
panel-common.c: In function 'panel_device_type_to_localized_string':
panel-common.c:74:14: error: 'NM_DEVICE_TYPE_GSM' undeclared (first use in this function)
panel-common.c:75:14: error: 'NM_DEVICE_TYPE_CDMA' undeclared (first use in this function)
panel-common.c: In function 'panel_device_type_to_sortable_string':
panel-common.c:109:14: error: 'NM_DEVICE_TYPE_GSM' undeclared (first use in this function)
panel-common.c:110:14: error: 'NM_DEVICE_TYPE_CDMA' undeclared (first use in this function)
make[3]: *** [panel-common.lo] Error 1
make[3]: *** Waiting for unfinished jobs....
make[3]: *** [cc-network-panel.lo] Error 1

Comment 1 Alexandre Rostovtsev (RETIRED) gentoo-dev

2011-02-27 18:20:38 UTC

Created attachment 264081 [details, diff]
patch for new NetworkManager API

This patch by Daniel Trebbien from https://bugzilla.gnome.org/show_bug.cgi?id=643390 allows gnome-control-center to use the new API.

Comment 2 Nirbheek Chauhan (RETIRED) gentoo-dev

2011-02-28 07:47:14 UTC

This has been fixed, thanks for reporting!