Summary: | media-video/avidemux-2.5.4-r1 fails to build with >=media-libs/x264-0.0.20110223 | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Patrick <mail> |
Component: | Current packages | Assignee: | Markos Chandras (RETIRED) <hwoarang> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | Adrian.Bassett, chris, conardcox, dan.dickey, defuebr, dschridde+gentoobugs, gekkoman, gentoo-bugs, ghutzl, giovanni.bobbio, it-knodel, jrmalaq, jwbraun, kmeagher, media-video, michele, mobiusstripper, phobosk, qt, rktspm, SuloevDmitry, sven.koehler, vityokster, v_2e, waterloo2005, xangel1, yamadharma, zeekec, zima |
Priority: | High | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
Complete build log
c:\Users\jansa\Documents\avidemux-2.5.4-x264-X264_WEIGHTP_BLIND-fix.patch avidemux-2.5.4-r1.ebuild.diff Avidemux 2.5 r6787 (Patch) avidemux-2.5.4-x264-version-fix.patch avidemux-2.5.4-r2.ebuild |
Description
Patrick
2011-02-25 05:20:01 UTC
Created attachment 263745 [details]
Complete build log
Probably caused by the recent update to media-libs/x264-0.0.20110223. Created attachment 263769 [details, diff] c:\Users\jansa\Documents\avidemux-2.5.4-x264-X264_WEIGHTP_BLIND-fix.patch Fix from archlinux http://mailman.archlinux.org/pipermail/arch-commits/2011-January/115691.html Created attachment 263771 [details, diff]
avidemux-2.5.4-r1.ebuild.diff
I dropped the patch in /etc/portage/patches/media-video/avidemux and avidemux emerged just fine. Thanks, Erik Worked here too!! Pardon me if I do not understand why this problem should be solved by patching avidemux and why it is not reported against media-libs/x264. 1/ I would believe more coherent to patch media-libs/x264 x264.h 2/ If this patch is committed in the portage tree, then build will be broken for all those running stable media-libs/x264 3/ I do not find pertinent to force >= media-libs/x264-0.0.20110223 in avidemux' ebuild yet. (In reply to comment #7) > Pardon me if I do not understand why this problem should be solved by patching > avidemux and why it is not reported against media-libs/x264. Because upstream is: http://lists.berlios.de/pipermail/avidemux-svn-commit/2010-November/003964.html P.S. This patch is probably better as it handles muptiple x264 versions. (In reply to comment #8) > http://lists.berlios.de/pipermail/avidemux-svn-commit/2010-November/003964.html > > P.S. This patch is probably better as it handles muptiple x264 versions. Indeed ! (In reply to comment #4) > Created an attachment (id=263771) [details] > avidemux-2.5.4-r1.ebuild.diff > Note this diff is absolute referenced to full portage path. One should really be making changes within an overlay to avoid clobbering files on next sync. To use this patch properly in an overlay one will need to establish the correct -p option for patch; most likely -p6 which is not elegant. Patch itself works fine. *** Bug 357195 has been marked as a duplicate of this bug. *** Is there any fix to this yet? There will be as soon as I manage to understand how this damn websvn interface works so I can export the patch of that specific revision Created attachment 265409 [details, diff] Avidemux 2.5 r6787 (Patch) (In reply to comment #13) > There will be as soon as I manage to understand how this damn websvn interface > works so I can export the patch of that specific revision I do not think WebSVN or ViewVC can do this. I used the following instead: svn diff -c6787 svn://svn.berlios.de/avidemux > avidemux-2.5-r6787.patch *** Bug 358179 has been marked as a duplicate of this bug. *** Thanks for the patch. I will sort this out today Created attachment 265619 [details, diff]
avidemux-2.5.4-x264-version-fix.patch
This patch is taken from upstream and is almost as the proposed patches above, but it is with fixed lines numbers etc.
With it avidemux compiles ok. I have not tested if the x264 plug-in works as expected (the qt4 version of avidemux).
Please check it and upload it to main gentoo tree with the avidemux-2.5.4-r2.ebuild that i am uploading next.
Created attachment 265621 [details]
avidemux-2.5.4-r2.ebuild
This is the actual ebuild that uses the avidemux-2.5.4-x264-version-fix.patch.
Thank you very much. This *should* be fixed in -r2. Please test it and report any problems. I had this problem before. Now avidemux compiles fine. Thank you. It can confirm it fixed it for me...AMD64. Thank you, great job! |