Summary: | games-fps/prboom+ - PrBoom+ is a Doom source port developed from the original PrBoom project by Andrey Budko | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Alexander Korshun <korshun70> |
Component: | New packages | Assignee: | Default Assignee for New Packages <maintainer-wanted> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | andrey.aleksandrovich |
Priority: | High | Keywords: | PullRequest |
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | http://prboom-plus.sourceforge.net/ | ||
See Also: | https://github.com/gentoo/gentoo/pull/12297 | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
My ebuild. It has problems.
prboom-plus-2.5.1.3.ebuild metadata.xml to supply use flag descriptions prboom-plus-2.5.1.4.ebuild |
Description
Alexander Korshun
2010-09-19 11:08:41 UTC
Created attachment 247985 [details]
My ebuild. It has problems.
Do not add it as-is. It has problems I described already.
Created attachment 317534 [details] prboom-plus-2.5.1.3.ebuild 1. I updated the ebuild to the latest version, 2.5.1.3. 2. I added several use flags in order to make the compilation much more configurable. 3. I changed the description to match the one from the PrBoom+ home page on Sourceforge. 4. I added ~x86 keyword as I have tested it on my 32-bit system. 5. I removed all blockers. I referenced https://bugs.gentoo.org/show_bug.cgi?id=159087 to find out why a blocker was in place in the first place. In short, the issue no longer exists. I have lsdldoom, prboom, and prboom-plus installed simultaneously; I had no file collision issues. 6. Ebuild still uses the original prboom icon because prboom-plus does not supply one of it's own. However, I rename the icon before installation in order to avoid a file collision with prboom. 7. I removed the nvidia bug detection. I have no way of knowing if the bug even exists in the prboom-plus code, and even if it did the patch would not apply to the prboom-plus source code. 8. I also removed the libpng patch. Tested with libpng-1.5.11, the source builds fine with no patches. 9. I removed a couple of sed functions which alter the Makefile and changed the src_install procedure so they're now unnecessary. Please note that I have not tested all possible use flag combinations, so I suppose it's possible that some use flag combinations may not work. Created attachment 317536 [details]
metadata.xml to supply use flag descriptions
By the way, I am adding the ebuild to paddymac overlay until such time as it makes it into portage.
(In reply to comment #3) > Created attachment 317536 [details] > metadata.xml to supply use flag descriptions > > By the way, I am adding the ebuild to paddymac overlay until such time as it > makes it into portage. contribute to sunrise instead, there is an experimental github overlay that is synced with sunrise beta https://github.com/hasufell/sunrise you can send pull requests there *** Bug 650402 has been marked as a duplicate of this bug. *** Created attachment 524198 [details]
prboom-plus-2.5.1.4.ebuild
(In reply to Andrey Aleksandrovich from comment #6) > Created attachment 524198 [details] > prboom-plus-2.5.1.4.ebuild Thanks for your work, to have hopes for ebuild repo it would need to be ported away from games.eclass and be at EAPI-7. The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=54d69b5150e342464abbf45d4699877b32a2efc2 commit 54d69b5150e342464abbf45d4699877b32a2efc2 Author: William Breathitt Gray <vilhelm.gray@gmail.com> AuthorDate: 2019-06-20 07:30:38 +0000 Commit: James Le Cuirot <chewi@gentoo.org> CommitDate: 2019-06-24 19:57:41 +0000 games-fps/prboom-plus: Introduce version 2.5.1.4 Closes: https://bugs.gentoo.org/338027 Package-Manager: Portage-2.3.67, Repoman-2.3.15 Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com> Closes: https://github.com/gentoo/gentoo/pull/12297 Signed-off-by: James Le Cuirot <chewi@gentoo.org> games-fps/prboom-plus/Manifest | 1 + ....1.4-Remove-nonstandard-gamesdir-variable.patch | 33 +++++++++++ games-fps/prboom-plus/metadata.xml | 33 +++++++++++ games-fps/prboom-plus/prboom-plus-2.5.1.4.ebuild | 68 ++++++++++++++++++++++ 4 files changed, 135 insertions(+) |