Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 337903

Summary: net-misc/sipcalc _FORTIFY_SOURCE indicates presence of overflow
Product: Gentoo Linux Reporter: Diego Elio Pettenò (RETIRED) <flameeyes>
Component: Current packagesAssignee: Krzysztof Pawlik (RETIRED) <nelchael>
Severity: major CC: hardened
Priority: High    
Version: unspecified   
Hardware: All   
OS: Linux   
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 259417    
Attachments: Build log
Patch to sipcalc-1.1.4.ebuild to fix reported overflow (and one other warning)

Description Diego Elio Pettenò (RETIRED) gentoo-dev 2010-09-18 12:02:13 UTC
You're receiving this bug because the package in Summary has produced _FORTIFY_SOURCE related warnings indicating the presence of a sure overflow in a static buffer.

Even though this is not always an indication of a security problem it might even be. So please check this out ASAP.

By the way, _FORTIFY_SOURCE is disabled when you disable optimisation, so don't try finding out the cause using -O0.

Your friendly neighborhood tinderboxer
Comment 1 Diego Elio Pettenò (RETIRED) gentoo-dev 2010-09-18 12:02:24 UTC
Created attachment 247813 [details]
Build log
Comment 2 Kevin Pyle 2010-11-11 03:45:08 UTC
Created attachment 253949 [details, diff]
Patch to sipcalc-1.1.4.ebuild to fix reported overflow (and one other warning)

This patch adds two sed statements.  The first fixes a format string warning.  The second adjusts the offending snprintf statements to use sizeof() to compute the length, which fixes the _FORTIFY_SOURCE warning.
Comment 3 Krzysztof Pawlik (RETIRED) gentoo-dev 2010-11-11 12:50:03 UTC
Version 1.1.5 which is in the tree doesn't suffer from this issue. Thank you Kevin for your contribution.