Bug 334759

Summary:	sys-block/smp_utils does not respect LDFLAGS
Product:	Gentoo Linux	Reporter:	Diego Elio Pettenò (RETIRED) <flameeyes>
Component:	New packages	Assignee:	Gentoo's Team for Core System packages <base-system>
Status:	RESOLVED FIXED
Severity:	QA	CC:	esigra
Priority:	High
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	331933
Attachments:	Build log Patch to smp_utils-0.94.ebuild to respect LDFLAGS, and make other improvements

Description Diego Elio Pettenò (RETIRED) gentoo-dev

2010-08-27 09:01:33 UTC

See attached build log.

(Please do not complain about the need for looking at the build log until you can provide an easy way to open bugs with the correct data picked out of a tinderbox log. Thanks.)

Comment 1 Diego Elio Pettenò (RETIRED) gentoo-dev

2010-08-27 09:01:45 UTC

Created attachment 244879 [details]
Build log

Comment 2 Kevin Pyle 2010-09-04 22:17:26 UTC

Created attachment 246050 [details, diff]
Patch to smp_utils-0.94.ebuild to respect LDFLAGS, and make other improvements

This patch makes the following changes:

- Switch to a single sed that hits all the Makefiles, instead of running sed individually on each one
- Delete CFLAGS and LDFLAGS assignments so that user values are respected.  Upstream had assigned LDFLAGS to be empty, triggering the original bug report.
- Add $(CFLAGS) to link lines, to handle any cases where -f options need to be specified at both compile and link phases.
- Switch to builtin rule for compiling .o files.  This required moving upstream -I and -D lines into $CPPFLAGS.
- Rework recursive descent so that libsmp.a is not rebuilt during 'make install', since rebuilding it caused Make to then relink one of the outputs.
- Use CHOST-qualified values for CC and AR.
- Use emake for install, since it works fine with MAKEOPTS=-j.

Comment 3 Tim Harder gentoo-dev

2011-08-30 09:32:23 UTC

Fixed in 0.96 in CVS.