Bug 331859 – app-misc/mouseremote does not respect LDFLAGS

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Diego Elio Pettenò (RETIRED) 2010-08-09 16:40:38 UTC]

See attached build log.

(Please do not complain about the need for looking at the build log until you can provide an easy way to open bugs with the correct data picked out of a tinderbox log. Thanks.)

[Comment 1 Diego Elio Pettenò (RETIRED) 2010-08-09 16:40:53 UTC]

Created attachment 242069 [details]
Build log

[Comment 2 Jeroen Roovers (RETIRED) 2010-08-11 01:03:59 UTC]

*** Bug 331861 has been marked as a duplicate of this bug. ***

[Comment 3 Dane Smith (RETIRED) 2010-08-13 04:18:37 UTC]

Created attachment 242701 [details]
Diff from mouseremote-0.90

I made a good number of changes, and as this is a stable package on x86, this should probably be revbumped.

Changelist:
Resolved the LDFLAGS issue. That is taken care of in one of the following patches. To do this in a readable manner, I removed the changes to the Makefile from the rather large mouseremote-gentoo.patch file and created a .diff for just Makefile changes.

I also made a number of cosmetic changes. Moved epatch to src_unpack. Added a ton of || die statements in src_install. Modified emake in src_compile to respect the toolchain instead of blindly using gcc. I think that's it.

I will be attaching the diff from the mouseremote-gentoo patch (a diff from a patch.. a bit convoluted.) I will also attach the new mouseremote-gentoo.patch file to make it easier.

I will also be attaching my patch to the Makefile.

[Comment 4 Dane Smith (RETIRED) 2010-08-13 04:19:42 UTC]

Created attachment 242703 [details]
The *real* diff from mouseremote-0.90.ebuild

Same comment as above, this time with the correct attachment.

[Comment 5 Dane Smith (RETIRED) 2010-08-13 04:21:00 UTC]

Created attachment 242705 [details]
Diff from mouseremote-gentoo.patch

I think a diff from a patch is a little odd myself, but just in case it will make someone's life a little easier, here it is. I'll attach the full modified patch next.

[Comment 6 Dane Smith (RETIRED) 2010-08-13 04:21:41 UTC]

Created attachment 242707 [details]
New mouseremote-gentoo.patch

Full patch. This should replace the one currently in the tree.

[Comment 7 Dane Smith (RETIRED) 2010-08-13 04:22:54 UTC]

Created attachment 242709 [details]
mouseremote-0.90-makefile.diff

New patch to the Makefile to force LDFLAGS compliance (among other things). Full name is mouseremote-0.90-makefile.diff

[Comment 8 Markos Chandras (RETIRED) 2010-08-13 15:30:42 UTC]

+*mouseremote-0.90-r1 (13 Aug 2010)
+
+  13 Aug 2010; Markos Chandras <[e-mail]>
+  +mouseremote-0.90-r1.ebuild, +files/mouseremote-0.90-makefile.diff,
+  files/mouseremote-gentoo.diff:
+  Apply patches from Dane Smith <[e-mail]> to respect
+  LDFLAGS,CC, ebuild QA fixes. Bug #331859
+