Summary: | Please review EAPI3/Gentoo Prefix changes for =net-misc/whois-5.0.6 | ||
---|---|---|---|
Product: | Gentoo/Alt | Reporter: | Jeremy Olexa (darkside) (RETIRED) <darkside> |
Component: | Prefix Support | Assignee: | Gentoo's Team for Core System packages <base-system> |
Status: | RESOLVED FIXED | ||
Severity: | enhancement | CC: | prefix |
Priority: | High | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 315803 |
Description
Jeremy Olexa (darkside) (RETIRED)
2010-07-28 14:48:56 UTC
If it works, should be fine.. wouldn't it need a dummy src_configure() { :; } though? (In reply to comment #1) > If it works, should be fine.. wouldn't it need a dummy src_configure() { :; } > though? > Well, you are correct that src_confgiure() will be ran here. But that calls econf and econf checks for existance of $ECONF_SOURCE/configure (which doesn't exist in this package. So, I feel it is a style choice. Do you care if I add a dummy or not? <snip> >>> Source prepared. >>> Configuring source in /var/tmp/portage/net-misc/whois-5.0.6/work/whois-5.0.6 ... >>> Source configured. <snip> TBH I'm always partial to add dummy when we expect a function to be no-op, had bad experience with automagic defaults changing. (In reply to comment #3) > TBH I'm always partial to add dummy when we expect a function to be no-op, had > bad experience with automagic defaults changing. > OK, committed comment #0 with dummy src_configure. thx. |