Summary: | dev-util/aap: Verify and potentially improve Python-related code | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Arfrever Frehtes Taifersar Arahesis (RETIRED) <arfrever> |
Component: | Current packages | Assignee: | Vim Maintainers <vim> |
Status: | RESOLVED OBSOLETE | ||
Severity: | normal | CC: | idella4 |
Priority: | High | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 308257 | ||
Attachments: |
ebuild patch
revised ebuild patch revised ebuild patch revised ebuild patch revised ebuild patch revised ebuild patch revised ebuild patch removed the remove |
Description
Arfrever Frehtes Taifersar Arahesis (RETIRED)
2010-06-16 20:11:11 UTC
Created attachment 292391 [details]
ebuild patch
tested all ok. bumped to EAPI 3
(In reply to comment #1) This package needs Python 2. Shebang in aap script should be fixed. 'python_mod_optimize /usr/share/aap' and 'python_mod_cleanup /usr/share/aap' should added. Created attachment 292997 [details, diff]
revised ebuild patch
done
(In reply to comment #3) s/src_pkg_setup/pkg_setup/ Please read documentation of all ebuild phases. ${ED} should be quoted. Created attachment 293311 [details, diff]
revised ebuild patch
(In reply to comment #5) Delete '>=dev-lang/python-1.5' from RDEPEND. Created attachment 293659 [details, diff]
revised ebuild patch
(In reply to comment #7) Set empty RDEPEND. s/src_pkg_setup/pkg_setup/ Created attachment 293813 [details, diff]
revised ebuild patch
(In reply to comment #9) This patch doesn't apply cleanly. Created attachment 293975 [details, diff]
revised ebuild patch
(In reply to comment #11) Compare this patch with patch from comment #9 and notice that calls to python_convert_shebangs(), python_mod_optimize() and python_mod_cleanup() incorrectly disappeared. Created attachment 293985 [details, diff]
revised ebuild patch
(In reply to comment #13) You shouldn't remove this line: cp -R doc/* "${D}"/usr/share/doc/${PF}/html Created attachment 293991 [details, diff]
removed the remove
done
This approach was changed by the -r1 python eclasses |