Summary: | sys-apps/paludis: Verify and potentially improve Python-related code | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Arfrever Frehtes Taifersar Arahesis (RETIRED) <arfrever> |
Component: | Current packages | Assignee: | Jeff (JD) Horelick (RETIRED) <jdhore> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | idella4, mgorny |
Priority: | High | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 308257 | ||
Attachments: |
ebuild patch
ebuild patch revised r revised ebuild patch revised ebuild patch revised ebuild patch ebuild patch revised ebuild patch |
Description
Arfrever Frehtes Taifersar Arahesis (RETIRED)
2010-04-24 18:17:49 UTC
Created attachment 292307 [details]
ebuild patch
seems all the others need
sys-apps/paludis/paludis-0.58.5.ebuild: please migrate from 'bash-completion' to 'bash-completion-r1' on line
ABI {2.6 2.7 3.1 .32}, usual version bump to
EAPI 3, tested, all AOK PYTHON_DEPEND="python-bindings? 2:2.6" python_pkg_setup() and python_convert_shebangs() should be called only with USE="python-bindings". Created attachment 292479 [details]
ebuild patch revised
thanks Arfrever
(In reply to comment #4) PYTHON_DEPEND still wrong :( . Created attachment 293001 [details, diff]
r
(In reply to comment #6) This patch is identical to previous patch. Created attachment 293315 [details, diff]
revised ebuild patch
(In reply to comment #8) Add 'python_set_active_version 2' in pkg_setup(). Don't change DESTDIR="${D}" to DESTDIR="${ED}". Created attachment 293667 [details, diff]
revised ebuild patch
(In reply to comment #10) python_convert_shebangs() is not needed in this package. Created attachment 293773 [details, diff]
revised ebuild patch
(In reply to comment #12) 'python_set_active_version 2' (which was in previous patch) is still needed. Don't change DESTDIR="${D}" to DESTDIR="${ED}". If you replace dobashcompletion() with dobashcomp(), then unset no longer used BASHCOMPLETION_NAME variable. Created attachment 293815 [details, diff]
ebuild patch
(In reply to comment #14) Call python_set_active_version() before python_pkg_setup(). Suggestion #3 from comment #13 is only about variable, not call to dobashcomp(): - BASHCOMPLETION_NAME="cave" dobashcompletion bash-completion/cave + dobashcomp bash-completion/cave Created attachment 293981 [details, diff]
revised ebuild patch
Improved in 1.4.2. |