Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 316931 - sys-apps/paludis: Verify and potentially improve Python-related code
Summary: sys-apps/paludis: Verify and potentially improve Python-related code
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: High normal (vote)
Assignee: Jeff (JD) Horelick (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 308257
  Show dependency tree
 
Reported: 2010-04-24 18:17 UTC by Arfrever Frehtes Taifersar Arahesis (RETIRED)
Modified: 2013-10-20 15:56 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
ebuild patch (paludis.patch,1.92 KB, text/plain)
2011-11-12 18:06 UTC, Ian Delaney (RETIRED)
Details
ebuild patch revised (paludis.patch,1.99 KB, text/plain)
2011-11-14 07:53 UTC, Ian Delaney (RETIRED)
Details
r (paludis.patch,1.99 KB, patch)
2011-11-18 17:53 UTC, Ian Delaney (RETIRED)
Details | Diff
revised ebuild patch (paludis.patch,2.01 KB, patch)
2011-11-21 14:12 UTC, Ian Delaney (RETIRED)
Details | Diff
revised ebuild patch (paludis.patch,1.82 KB, patch)
2011-11-24 22:13 UTC, Ian Delaney (RETIRED)
Details | Diff
revised ebuild patch (paludis.patch,2.04 KB, patch)
2011-11-25 23:08 UTC, Ian Delaney (RETIRED)
Details | Diff
ebuild patch (paludis.patch,2.02 KB, patch)
2011-11-26 11:40 UTC, Ian Delaney (RETIRED)
Details | Diff
revised ebuild patch (paludis.patch,1.90 KB, patch)
2011-11-27 20:43 UTC, Ian Delaney (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Arfrever Frehtes Taifersar Arahesis (RETIRED) gentoo-dev 2010-04-24 18:17:49 UTC
- If this package can be used as a library and installs Python modules
  (*.so or *.py) into site-packages directories, then consider supporting
  installation for multiple Python versions.
  Please read section "Types of packages" in documentation [1] to decide
  if this package can support installation for multiple Python versions.

- Ensure that the ebuilds do not use deprecated functions or variables.

- Please check if Python 3 is supported by this package. You can temporarily
  set Python 3 as main active version of Python to properly test if this
  package supports Python 3.

- If this package does not support Python 3:
  - Specify dependency on Python 2.
    You can use PYTHON_DEPEND helper variable, which should be set before
    inheriting of python eclass.
    Please read section "Specification of dependency on Python" in
    documentation [1].

  - If this package cannot support installation for multiple versions of
    Python, then set active version of Python using
    python_set_active_version().

  - Ensure that shebangs in installed scripts specify correct version of
    Python. If shebangs are too generic (e.g. '#!/usr/bin/python'), then you
    can use python_convert_shebangs() to convert shebangs.
    (Wrapper scripts generated by python_generate_wrapper_scripts() do not
    require any changes.)
    Please read section "Shebangs in installed scripts" in documentation [1].

  - To ensure that changes applied to the ebuilds are sufficient, please
    temporarily set Python 3 as main active version of Python and test if
    this package can be properly installed and if it works at run time.

Please see documentation [1] for more details.
[1] http://www.gentoo.org/proj/en/Python/developersguide.xml
Comment 1 Ian Delaney (RETIRED) gentoo-dev 2011-11-12 18:06:35 UTC
Created attachment 292307 [details]
ebuild patch

seems all the others need 
  sys-apps/paludis/paludis-0.58.5.ebuild: please migrate from 'bash-completion' to 'bash-completion-r1' on line
ABI {2.6 2.7 3.1 .32}, usual version bump to
Comment 2 Ian Delaney (RETIRED) gentoo-dev 2011-11-12 18:08:06 UTC
EAPI 3, tested, all AOK
Comment 3 Arfrever Frehtes Taifersar Arahesis 2011-11-13 01:21:45 UTC
PYTHON_DEPEND="python-bindings? 2:2.6"

python_pkg_setup() and python_convert_shebangs() should be called only with USE="python-bindings".
Comment 4 Ian Delaney (RETIRED) gentoo-dev 2011-11-14 07:53:29 UTC
Created attachment 292479 [details]
ebuild patch revised

thanks Arfrever
Comment 5 Arfrever Frehtes Taifersar Arahesis 2011-11-14 17:47:23 UTC
(In reply to comment #4)

PYTHON_DEPEND still wrong :( .
Comment 6 Ian Delaney (RETIRED) gentoo-dev 2011-11-18 17:53:06 UTC
Created attachment 293001 [details, diff]
r
Comment 7 Arfrever Frehtes Taifersar Arahesis 2011-11-20 03:39:54 UTC
(In reply to comment #6)

This patch is identical to previous patch.
Comment 8 Ian Delaney (RETIRED) gentoo-dev 2011-11-21 14:12:11 UTC
Created attachment 293315 [details, diff]
revised ebuild patch
Comment 9 Arfrever Frehtes Taifersar Arahesis 2011-11-23 19:39:07 UTC
(In reply to comment #8)

Add 'python_set_active_version 2' in pkg_setup().
Don't change DESTDIR="${D}" to DESTDIR="${ED}".
Comment 10 Ian Delaney (RETIRED) gentoo-dev 2011-11-24 22:13:05 UTC
Created attachment 293667 [details, diff]
revised ebuild patch
Comment 11 Arfrever Frehtes Taifersar Arahesis 2011-11-25 22:55:39 UTC
(In reply to comment #10)

python_convert_shebangs() is not needed in this package.
Comment 12 Ian Delaney (RETIRED) gentoo-dev 2011-11-25 23:08:38 UTC
Created attachment 293773 [details, diff]
revised ebuild patch
Comment 13 Arfrever Frehtes Taifersar Arahesis 2011-11-25 23:16:51 UTC
(In reply to comment #12)

'python_set_active_version 2' (which was in previous patch) is still needed.

Don't change DESTDIR="${D}" to DESTDIR="${ED}".

If you replace dobashcompletion() with dobashcomp(), then unset no longer used BASHCOMPLETION_NAME variable.
Comment 14 Ian Delaney (RETIRED) gentoo-dev 2011-11-26 11:40:01 UTC
Created attachment 293815 [details, diff]
ebuild patch
Comment 15 Arfrever Frehtes Taifersar Arahesis 2011-11-27 18:17:58 UTC
(In reply to comment #14)

Call python_set_active_version() before python_pkg_setup().

Suggestion #3 from comment #13 is only about variable, not call to dobashcomp():

-	BASHCOMPLETION_NAME="cave" dobashcompletion bash-completion/cave
+	dobashcomp bash-completion/cave
Comment 16 Ian Delaney (RETIRED) gentoo-dev 2011-11-27 20:43:49 UTC
Created attachment 293981 [details, diff]
revised ebuild patch
Comment 17 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2013-10-20 15:56:56 UTC
Improved in 1.4.2.