| Summary: | net-voip/telepathy-butterfly: Verify and potentially improve Python-related code | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Arfrever Frehtes Taifersar Arahesis (RETIRED) <arfrever> |
| Component: | Current packages | Assignee: | voip herd (OBSOLETE) <voip+disabled> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | gnome |
| Priority: | High | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Bug Depends on: | |||
| Bug Blocks: | 308257 | ||
| Attachments: | telepathy-butterfly-0.5.1.ebuild.patch | ||
Created attachment 235313 [details, diff]
telepathy-butterfly-0.5.1.ebuild.patch
This patch only removes deprecation warnings.
I will commit this patch, if you don't object in 1 week.
go for it Comment on attachment 235313 [details, diff]
telepathy-butterfly-0.5.1.ebuild.patch
Committed.
Should be fixed in telepathy-butterfly-0.5.15 There are syntax errors with Python 3.
Please add:
pkg_postinst() {
python_mod_optimize butterfly
}
pkg_postrm() {
python_mod_cleanup butterfly
}
Done, thanks a lot (In reply to comment #5) > There are syntax errors with Python 3. > Wouldn't be possible to add some kind of test or warning for preventing errors like this? You still need to update dependencies and restrict 3.* Python ABIs. Calling python_mod_optimize() allows to detect syntax errors. This package depends on >=net-libs/libproxy-0.3.1[python], but net-libs/libproxy currently doesn't support installation for multiple Python ABIs. (In reply to comment #7) > You still need to update dependencies and restrict 3.* Python ABIs. Then, looks like package passes configure and compiles with python3 but later python_optimize fails :-S > Calling python_mod_optimize() allows to detect syntax errors. > Isn't there any way for checking python stuff is not being "optimized"? |
- If this package can be used as a library and installs Python modules (*.so or *.py) into site-packages directories, then consider supporting installation for multiple Python versions. Please read section "Types of packages" in documentation [1] to decide if this package can support installation for multiple Python versions. - Ensure that the ebuilds do not use deprecated functions or variables. - Please check if Python 3 is supported by this package. You can temporarily set Python 3 as main active version of Python to properly test if this package supports Python 3. - If this package does not support Python 3: - Specify dependency on Python 2. You can use PYTHON_DEPEND helper variable, which should be set before inheriting of python eclass. Please read section "Specification of dependency on Python" in documentation [1]. - If this package cannot support installation for multiple versions of Python, then set active version of Python using python_set_active_version(). - Ensure that shebangs in installed scripts specify correct version of Python. If shebangs are too generic (e.g. '#!/usr/bin/python'), then you can use python_convert_shebangs() to convert shebangs. (Wrapper scripts generated by python_generate_wrapper_scripts() do not require any changes.) Please read section "Shebangs in installed scripts" in documentation [1]. - To ensure that changes applied to the ebuilds are sufficient, please temporarily set Python 3 as main active version of Python and test if this package can be properly installed and if it works at run time. Please see documentation [1] for more details. [1] http://www.gentoo.org/proj/en/Python/developersguide.xml