Summary: | media-sound/a2jmidid: Verify and potentially improve Python-related code | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Arfrever Frehtes Taifersar Arahesis (RETIRED) <arfrever> |
Component: | Current packages | Assignee: | Alexis Ballier <aballier> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | idella4, kripton, l33tmmx, proaudio, proxy-maint |
Priority: | High | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.gentoo.org/show_bug.cgi?id=428462 | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 308257 | ||
Attachments: |
ebuild patch
ebuild patch revised revised ebuild patch r a2jmidid.patch |
Description
Arfrever Frehtes Taifersar Arahesis (RETIRED)
2010-04-08 19:39:31 UTC
Created attachment 292289 [details]
ebuild patch
Needs ABI 2.6 2.7.
Tested, all AOK. Usual bump EAPI to 3
also * QA Notice: Files built without respecting LDFLAGS have been detected * Please include the following list of files in your report: * /usr/bin/j2amidi_bridge * /usr/bin/a2jmidi_bridge * /usr/bin/a2jmidid (In reply to comment #1) Portage itself requires Python >=2.6 and it has no relation to Python version required by other packages. If you install sys-apps/portage with USE="python3", then you will be able to set active version of Python 2 to 2.4 or 2.5 and still use Portage (Portage will use active version of Python 3 regardless of active version of Python 2). PYTHON_DEPEND specifies build-time and run-time dependency on Python, but this package has only build-time dependency on Python. Created attachment 292493 [details, diff]
ebuild patch revised
done
(In reply to comment #4) Please re-read comment #3. Created attachment 292605 [details, diff]
revised ebuild patch
this, I suspect
(In reply to comment #6) PYTHON_DEPEND specifies build-time and run-time dependency on Python, but this package has only build-time dependency on Python. Created attachment 293085 [details, diff]
r
(In reply to comment #8) This patch doesn't fix problem mentioned in comment #7 and additionally contains a regression (lack of 'python_set_active_version 2'). python_convert_shebangs() is probably not needed. If any Python scripts were installed, then there should be run-time dependency on Python. Created attachment 319718 [details, diff]
a2jmidid.patch
See also #417701 (In reply to comment #10) > Created attachment 319718 [details, diff] [details, diff] > a2jmidid.patch simplified and applied, thanks |