Bug 312145 – dev-embedded/libftdi: Verify and potentially improve Python-related code

• Product: Gentoo Linux
• Status: RESOLVED OBSOLETE

[Description Arfrever Frehtes Taifersar Arahesis (RETIRED) 2010-03-30 17:04:17 UTC]

- If this package can be used as a library and installs Python modules
  (*.so or *.py) into site-packages directories, then consider supporting
  installation for multiple Python versions.
  Please read section "Types of packages" in documentation [1] to decide
  if this package can support installation for multiple Python versions.

- Ensure that the ebuilds do not use deprecated functions or variables.

- Please check if Python 3 is supported by this package. You can temporarily
  set Python 3 as main active version of Python to properly test if this
  package supports Python 3.

- If this package does not support Python 3:
  - Specify dependency on Python 2.
    You can use PYTHON_DEPEND helper variable, which should be set before
    inheriting of python eclass.
    Please read section "Specification of dependency on Python" in
    documentation [1].

  - If this package cannot support installation for multiple versions of
    Python, then set active version of Python using
    python_set_active_version().

  - Ensure that shebangs in installed scripts specify correct version of
    Python. If shebangs are too generic (e.g. '#!/usr/bin/python'), then you
    can use python_convert_shebangs() to convert shebangs.
    (Wrapper scripts generated by python_generate_wrapper_scripts() do not
    require any changes.)
    Please read section "Shebangs in installed scripts" in documentation [1].

  - To ensure that changes applied to the ebuilds are sufficient, please
    temporarily set Python 3 as main active version of Python and test if
    this package can be properly installed and if it works at run time.

Please see documentation [1] for more details.
[1] http://www.gentoo.org/proj/en/Python/developersguide.xml

[Comment 1 Ian Delaney (RETIRED) 2011-11-15 10:48:12 UTC]

Created attachment 292611 [details]
ebuild patch

Tested, works.

[Comment 2 Ian Delaney (RETIRED) 2011-11-15 10:54:03 UTC]

correct, ooops vers, 0.17;  EAPI="32 ->"  EAPI="3"

[Comment 3 Arfrever Frehtes Taifersar Arahesis 2011-11-16 18:54:54 UTC]

(In reply to comment #1)

This package doesn't support Python 3.

[Comment 4 Ian Delaney (RETIRED) 2011-11-17 01:38:08 UTC]

Created attachment 292833 [details, diff]
r

[Comment 5 Arfrever Frehtes Taifersar Arahesis 2011-11-18 01:19:04 UTC]

(In reply to comment #4)

This patch modifies non-original ebuilds. It fails to apply to original ebuilds from gentoo-x86.

Changes in libftdi-0.17.ebuild are more wrong. Please make patches only for the newest ebuild in each slot.

This package has USE-conditional dependency on Python, so this should be reflected in PYTHON_DEPEND:
PYTHON_DEPEND="python? 2"

pkg_setup() {
	if use python; then
		python_set_active_version 2
		python_pkg_setup
	fi
}

[Comment 6 Ian Delaney (RETIRED) 2011-11-18 10:37:27 UTC]

Created attachment 292979 [details, diff]
revised ebuild patch

more practice

[Comment 7 Arfrever Frehtes Taifersar Arahesis 2011-11-20 02:45:47 UTC]

(In reply to comment #6)

This patch is reversed.

[Comment 8 Ian Delaney (RETIRED) 2011-11-21 08:53:27 UTC]

Created attachment 293281 [details, diff]
revised ebuild patch

[Comment 9 Pacho Ramos 2015-10-03 09:28:11 UTC]

This approach was changed by the -r1 python eclasses