Summary: | app-text/xmldiff: Verify and potentially improve Python-related code | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Arfrever Frehtes Taifersar Arahesis (RETIRED) <arfrever> |
Component: | Current packages | Assignee: | Michael Weber (RETIRED) <xmw> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | dabbott |
Priority: | High | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 308257 | ||
Attachments: |
xmldiff-0.6.9.ebuild.patch
xmldiff-0.6.9.ebuild.patch xmldiff-0.6.9-r1.ebuild xmldiff-0.6.9-r1.ebuild |
Description
Arfrever Frehtes Taifersar Arahesis (RETIRED)
2010-03-30 16:55:47 UTC
Created attachment 229871 [details, diff]
xmldiff-0.6.9.ebuild.patch
Only works with Python 2
python3.1 setup.py build
File "setup.py", line 121
except OSError, ex:
^
SyntaxError: invalid syntax
* ERROR: app-text/xmldiff-0.6.9-r1 failed:
* Building failed
patched ebuild works when Python 3 is set to active version.
arfrever is that the correct way?
RESTRICT_PYTHON_ABIS is for packages supporting installation for multiple Python ABIS. python_set_active_version() is for packages not supporting installation for multiple Python ABIs. distutils.eclass inherits python.eclass, so don't inherit python.eclass. Created attachment 229943 [details, diff]
xmldiff-0.6.9.ebuild.patch
Ok I think that is it.
Created attachment 229963 [details]
xmldiff-0.6.9-r1.ebuild
Created attachment 229967 [details]
xmldiff-0.6.9-r1.ebuild
fixed src_prepare()
(In reply to comment #2) > RESTRICT_PYTHON_ABIS is for packages supporting installation for multiple > Python ABIS. In the docs; Ebuilds not working with some versions of Python should set RESTRICT_PYTHON_ABIS # Package not supporting Python 3. RESTRICT_PYTHON_ABIS="3.*" so does this need to be in every ebuild because that covers both explanations. > python_set_active_version() is for packages not supporting installation for > multiple Python ABIs. > distutils.eclass inherits python.eclass, so don't inherit python.eclass. > SUPPORT_PYTHON_ABIS and RESTRICT_PYTHON_ABIS are for packages, which can be installed for e.g. both Python 2.6 and 2.7 simultaneously (not necessarily for Python 3.1). Ok, taking over by solving bug 349499. I'll use PYTHON_DEPEND="*" SUPPORT_PYTHON_ABIS="1" RESTRICT_PYTHON_ABIS="3.*" +*xmldiff-0.6.10 (03 Jan 2011) +*xmldiff-0.6.9-r1 (03 Jan 2011) + + 03 Jan 2011; Michael Weber <xmw@gentoo.org> +xmldiff-0.6.9-r1.ebuild, + +xmldiff-0.6.10.ebuild, metadata.xml: + Taking maintainership, resolving python issues (thanks to David Abbott on bug + 312129) and bumping to 0.6.10 (thanks to Stefan de Konink <stefan@konink.de> + on bug 349499). + You haven't committed these changes. second attempt, sorry for the inconvenicence second attempt, sorry for my failure |